-
Notifications
You must be signed in to change notification settings - Fork 173
Add --results-per-page query option #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Should we perhaps have a maximum upper bound?
Good idea; a maximum of 1000 results sounds practical. I tested the changes alongside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* added RDF ML notebooks * cleaning up the code a bit * completed regression and classification for SPARQL ML * added RDF ML notebooks * cleaning up the code a bit * completed regression and classification for SPARQL ML * Complete notebooks for SPARQL Classification - Regression and Link Prediction * Complete notebooks for SPARQL Classification - Regression and Link Prediction * Complete notebooks for SPARQL Classification - Regression and Link Prediction * Complete notebooks for SPARQL Classification - Regression and Link Prediction * Rename gremlin profile args for clarity (#249) Co-authored-by: Michael Chin <chnmch@amazon.com> * Add --results-per-page query option (#242) * Add -r option * Replace interval value * Add upper limit Co-authored-by: Michael Chin <chnmch@amazon.com> * Pin ipython<7.17.0 to patch vulnerability (#250) Co-authored-by: Michael Chin <chnmch@amazon.com> * Disable root logger output (#248) Co-authored-by: Michael Chin <chnmch@amazon.com> * Fix OC Bolt metadata (#255) * Fix OC Bolt query metadata output * Add OC metadata tests Co-authored-by: Michael Chin <chnmch@amazon.com> * Add groupby raw node result option (#253) * Add --group-by-raw query option * Add unit tests Co-authored-by: Michael Chin <chnmch@amazon.com> * Add Gremlin group-by-depth (#251) * Add --group-by-depth to Gremlin, modify OC with same explicit param * Add tests * PEP8 fixes Co-authored-by: Michael Chin <chnmch@amazon.com> * addressing comment left in PR #252 related to better conditional statements * Update ChangeLog.md * Suffix all doubles with d. Node batch reduced to 40 (#257) * Suffix all doubles with d. Node batch reduced to 40 * Update changelog for seed file changes * Update ChangeLog.md * Update ChangeLog.md Co-authored-by: Michael Chin <mchin188@yahoo.com> * Convert Decimal type results to float for Gremlin (#256) * Convert Decimal type values in GremlinNetwork * replace star import * Revert temp test change * Convert decimal type edge properties * Update Changelog Co-authored-by: Michael Chin <chnmch@amazon.com> * removed hard coded genre deletes, and moved them into the notebook. * removed hard coded genre deletes, and moved them into the notebook. * removed hard coded ciritcScore deletes, and moved them into the notebook. * removed hard coded link prediction retractions, and moved them into the notebook. * completed the Getting Started notebook with the pretrained models. * completed the Getting Started notebook with the pretrained models. * added RDF ML notebooks * cleaning up the code a bit * completed regression and classification for SPARQL ML * Complete notebooks for SPARQL Classification - Regression and Link Prediction * Complete notebooks for SPARQL Classification - Regression and Link Prediction * added RDF ML notebooks * cleaning up the code a bit * completed regression and classification for SPARQL ML * Complete notebooks for SPARQL Classification - Regression and Link Prediction * Complete notebooks for SPARQL Classification - Regression and Link Prediction * addressing comment left in PR #252 related to better conditional statements * removed hard coded genre deletes, and moved them into the notebook. * removed hard coded genre deletes, and moved them into the notebook. * removed hard coded ciritcScore deletes, and moved them into the notebook. * removed hard coded link prediction retractions, and moved them into the notebook. * completed the Getting Started notebook with the pretrained models. * completed the Getting Started notebook with the pretrained models. * tests passing for new SPARQL ML notebooks * Added detail fo new SPARQL/RDF ML notebooks to the change log * fixed bugs in link prediction, amde small improvements after review * updated location of pre-trained models Co-authored-by: Michael Chin <mchin188@yahoo.com> Co-authored-by: Michael Chin <chnmch@amazon.com> Co-authored-by: Kelvin Lawrence <gfxman@yahoo.com>
Issue #, if available: #135
Description of changes:
-r
/--results-per-page
to query magics. This allows for specifying a custom number of entries to display per page on the query results tab.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.