Skip to content

Add --no-scroll option #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Add --no-scroll option #243

merged 1 commit into from
Jan 10, 2022

Conversation

michaelnchin
Copy link
Member

Issue #, if available: #214

Description of changes:

  • Added --no-scroll option to query magics. If specified, each page of query results will be displayed unabridged without need for scrolling.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@krlawrence krlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have some sort of absolute maximum? I'm not sure what Jupyter will do if we try and display thousands of rows - is that even useful? Just food for thought. LGTM otherwise

@michaelnchin
Copy link
Member Author

I don't think it's needed specifically for this option, as the "Show X entries" modifier in the results tab already provides a hard limit for results displayed per page (max 100 by default). However, the user will be able to manually increase this limit via the changes in #242, so we should see about enforcing a maximum there.

@michaelnchin michaelnchin merged commit 161b67d into main Jan 10, 2022
@michaelnchin michaelnchin deleted the no-scroll branch January 10, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants