Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE-379] Allow longer billing project names and name workspace Google projects after workspace name only #3222

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

[CORE-379] Allow longer billing project names and name workspace Google projects after workspace name only #3222

wants to merge 3 commits into from

Conversation

marctalbott
Copy link
Contributor

Ticket: [CORE-379(https://broadworkbench.atlassian.net/browse/CORE-379)

  • Allow billing project names to be 60 characters
  • Use workspace name truncated to 30 characters for Google project name instead of the old format of {workspaceNamespace}--{workspaceName}

PR checklist

  • Include the JIRA issue number in the PR description and title
  • Make sure Swagger is updated if API changes
    • ...and Orchestration's Swagger too!
  • If you changed anything in model/, then you should publish a new official rawls-model and perform the corresponding dependency updates as specified in the README:
    • in the automation subdirectory
    • in workbench-libs
    • in firecloud-orchestration
  • Get two thumbsworth of PR review
  • Verify all tests go green, including CI tests
  • Squash commits and merge to develop (branches are automatically deleted after merging)
  • Inform other teams of any substantial changes via Slack and/or email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marctalbott