Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual pi network #543

Merged
merged 72 commits into from
Jan 24, 2025
Merged

Virtual pi network #543

merged 72 commits into from
Jan 24, 2025

Conversation

hibenj
Copy link
Collaborator

@hibenj hibenj commented Oct 16, 2024

Description

This PR includes the virtual_pi_network.hpp, virtual_pi_network.cpp(testing) and virtual_pi_network.rst(documentation), as well as the necessary changes in traits.hpp
The virtual PI network enhances all mockturtle network types to store duplicates of their PIs, called virtual PIs.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@hibenj hibenj requested review from marcelwa and Drewniok October 16, 2024 11:01
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 98.71912% with 14 lines in your changes missing coverage. Please review.

Project coverage is 98.13%. Comparing base (c47c5b0) to head (b690a0e).

Files with missing lines Patch % Lines
...clude/fiction/networks/views/static_depth_view.hpp 92.07% 8 Missing ⚠️
...thms/network_transformation/delete_virtual_pis.hpp 94.36% 4 Missing ⚠️
...clude/fiction/networks/views/mutable_rank_view.hpp 98.72% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   98.11%   98.13%   +0.02%     
==========================================
  Files         235      245      +10     
  Lines       36046    37144    +1098     
  Branches     1754     1804      +50     
==========================================
+ Hits        35368    36453    +1085     
- Misses        678      690      +12     
- Partials        0        1       +1     
Files with missing lines Coverage Δ
.../fiction/algorithms/verification/virtual_miter.hpp 100.00% <100.00%> (ø)
include/fiction/networks/virtual_pi_network.hpp 100.00% <100.00%> (ø)
...thms/network_transformation/delete_virtual_pis.cpp 100.00% <100.00%> (ø)
test/algorithms/verification/virtual_miter.cpp 100.00% <100.00%> (ø)
test/networks/views/mutable_rank_view.cpp 100.00% <100.00%> (ø)
test/networks/views/static_depth_view.cpp 100.00% <100.00%> (ø)
test/networks/virtual_pi_network.cpp 100.00% <100.00%> (ø)
...clude/fiction/networks/views/mutable_rank_view.hpp 98.72% <98.72%> (ø)
...thms/network_transformation/delete_virtual_pis.hpp 94.36% <94.36%> (ø)
...clude/fiction/networks/views/static_depth_view.hpp 92.07% <92.07%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c47c5b0...b690a0e. Read the comment docs.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your hard work on this PR, @hibenj and @Drewniok! 🙏 The code is in really good shape already. All comments I have are minor. No big restructuring necessary.

hibenj and others added 4 commits January 15, 2025 10:55
# Conflicts:
#	bindings/mnt/pyfiction/include/pyfiction/pybind11_mkdoc_docstrings.hpp
# Conflicts:
#	bindings/mnt/pyfiction/include/pyfiction/pybind11_mkdoc_docstrings.hpp
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

actions-user and others added 4 commits January 15, 2025 10:55
Signed-off-by: GitHub Actions <actions@github.com>
Signed-off-by: GitHub Actions <actions@github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@hibenj hibenj requested a review from marcelwa January 20, 2025 16:05
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the new naming of static_depth_view and mutable_rank_view. They do a great job providing an immediate intuition of their usefulness.

There are a few docstrings that I don't understand yet. I think you can clarify these quickly, though.

hibenj and others added 4 commits January 24, 2025 09:14
# Conflicts:
#	bindings/mnt/pyfiction/include/pyfiction/pybind11_mkdoc_docstrings.hpp
Signed-off-by: GitHub Actions <actions@github.com>
@hibenj hibenj requested a review from marcelwa January 24, 2025 10:00
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my remaining points so swiftly and a huge thank you for the terrific code addition! 🙏 It is ready to be merged in my opinion.

@marcelwa marcelwa merged commit 2ef6a23 into cda-tum:main Jan 24, 2025
2 checks passed
@marcelwa marcelwa added the enhancement New feature or request label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants