Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual pi network #543

Merged
merged 72 commits into from
Jan 24, 2025
Merged
Changes from 1 commit
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
73a8d64
:art: experiments_file_cleaned
hibenj Oct 15, 2024
9002bce
:memo: Update pyfiction docstrings
actions-user Oct 15, 2024
bb8f9c4
:art: modified traits.hpp
hibenj Oct 15, 2024
3c0ddeb
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj Oct 15, 2024
77b6867
:art: added docs
hibenj Oct 15, 2024
5aec291
:art: small modifications
hibenj Oct 15, 2024
d06c3cc
:memo: Update pyfiction docstrings
actions-user Oct 15, 2024
a3d07a2
:art: small adjustments
hibenj Oct 16, 2024
55abee5
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj Oct 16, 2024
fbe2eec
:memo: Update pyfiction docstrings
actions-user Oct 16, 2024
940c8af
:art: removed deep copy constructing on top of other network types.
hibenj Oct 16, 2024
366e67a
:memo: Update pyfiction docstrings
actions-user Oct 16, 2024
4dce17d
:art: corrected traits and added name_conservation test case
hibenj Oct 16, 2024
9530ef0
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj Oct 16, 2024
68b1eff
:memo: Update pyfiction docstrings
actions-user Oct 16, 2024
93c3baa
:art: docs updated
hibenj Oct 16, 2024
40eb89b
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj Oct 16, 2024
5c462f9
Merge branch 'main' into virtual_pi_network
hibenj Oct 16, 2024
6e5cd4b
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] Oct 16, 2024
5f83617
:art: optimized code coverage and fixed clang-tidy errors
hibenj Oct 17, 2024
4a130c1
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj Oct 17, 2024
ddecd61
:art: fixed function forwarding for foreach functions
hibenj Oct 17, 2024
482bb05
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] Oct 17, 2024
e4f5499
:art: fixed clang-tidy warnings for std::optional unchecked access
hibenj Oct 17, 2024
ba87098
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj Oct 17, 2024
c41d1fd
Merge branch 'main' into virtual_pi_network
marcelwa Nov 8, 2024
cfb50db
Merge branch 'main' into virtual_pi_network
hibenj Dec 3, 2024
8abbe4f
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj Dec 3, 2024
548380d
:art: improved code coverage
hibenj Dec 9, 2024
90af75c
Merge branch 'main' into virtual_pi_network
hibenj Dec 9, 2024
2863376
:art: removed clang-tidy errors
hibenj Dec 9, 2024
418f8c5
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] Dec 9, 2024
481e0d8
:heavy_plus_sign: virtual_miter added
hibenj Dec 9, 2024
da059df
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj Dec 9, 2024
0e82798
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] Dec 9, 2024
db97d7f
:heavy_plus_sign: extended_rank_view added
hibenj Dec 9, 2024
5edd332
:memo: Update pyfiction docstrings
actions-user Dec 9, 2024
a0637a4
:art: better code consistency and readability
hibenj Dec 10, 2024
0fd7942
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] Dec 10, 2024
41be15f
:memo: Update pyfiction docstrings
actions-user Dec 10, 2024
726a507
:art: clang tidy corrections
hibenj Dec 10, 2024
05c322d
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj Dec 10, 2024
0c88921
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] Dec 10, 2024
e835728
Merge branch 'virtual_pi_network' into extended_rank_view
hibenj Dec 13, 2024
14653f2
:memo: Update pyfiction docstrings
actions-user Dec 13, 2024
b10e337
:heavy_plus_sign: new depth_view and rank_view implementations.
hibenj Jan 2, 2025
1b920d0
Merge remote-tracking branch 'origin/extended_rank_view' into extende…
hibenj Jan 2, 2025
26d02fc
:memo: Update pyfiction docstrings
actions-user Jan 2, 2025
d1a9c04
Merge branch 'main' into extended_rank_view
hibenj Jan 2, 2025
01db414
:memo: Update pyfiction docstrings
actions-user Jan 2, 2025
fade0b4
Merge remote-tracking branch 'origin/extended_rank_view' into extende…
hibenj Jan 2, 2025
0a4555e
Merge branch 'main' into virtual_pi_network
hibenj Jan 2, 2025
3259bfb
Merge branch 'extended_rank_view' into virtual_pi_network
hibenj Jan 2, 2025
09fa50f
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] Jan 2, 2025
1cb8605
:art: virtual miter supports update_ranks and update_levels.
hibenj Jan 3, 2025
66c412f
Merge remote-tracking branch 'origin/virtual_pi_network' into virtual…
hibenj Jan 3, 2025
adb0893
:art: PI order adjustments
hibenj Jan 15, 2025
35099de
Merge remote-tracking branch 'origin/main'
hibenj Jan 15, 2025
1ba15c0
Merge branch 'main' into virtual_pi_network
hibenj Jan 15, 2025
bdc630e
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] Jan 15, 2025
dd980d2
:memo: Update pyfiction docstrings
actions-user Jan 15, 2025
b3918fa
:art: cleaned up files and added documentation
hibenj Jan 20, 2025
2fd1862
🎨 Incorporated pre-commit fixes
pre-commit-ci[bot] Jan 20, 2025
f843839
:memo: Update pyfiction docstrings
actions-user Jan 20, 2025
896c8b7
Merge branch 'cda-tum:main' into main
hibenj Jan 21, 2025
c486b4f
Merge branch 'main' into virtual_pi_network
hibenj Jan 21, 2025
818c82f
:art: added get_ranks member
hibenj Jan 21, 2025
b690a0e
:art: added const to members
hibenj Jan 21, 2025
734ca6e
:art: docstrings updated
hibenj Jan 24, 2025
7488fd7
Merge branch 'cda-tum:main' into main
hibenj Jan 24, 2025
4089f82
Merge branch 'main' into virtual_pi_network
hibenj Jan 24, 2025
277f226
:memo: Update pyfiction docstrings
actions-user Jan 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🎨 docstrings updated
hibenj committed Jan 24, 2025
commit 734ca6e149931441e26e599400336498e42d4488
16 changes: 13 additions & 3 deletions include/fiction/networks/views/mutable_rank_view.hpp
Original file line number Diff line number Diff line change
@@ -264,6 +264,8 @@ class mutable_rank_view<Ntk, false> : public fiction::static_depth_view<Ntk>
*/
[[nodiscard]] std::vector<node> get_ranks(const uint32_t level) const noexcept
{
assert(level < ranks.size() && "level must be less than the number of ranks");

return ranks[level];
}

@@ -431,7 +433,12 @@ class mutable_rank_view<Ntk, false> : public fiction::static_depth_view<Ntk>
}

/**
* Applies a given function to each PI in unranked order, so the order in the underlying `static_depth_view`.
* Applies a given function to each PI in unranked order. That means the order in the underlying
* `static_depth_view`. This corresponds to the order in the network's `_storage`, which reflects the order of PI
* creation.
*
* This ensures a consistent PI order, which is essential for equivalence checking, as `mockturtle` relies on the PI
* order for this process.
*
* @tparam Fn Functor type.
* @param fn The function to apply.
@@ -443,8 +450,11 @@ class mutable_rank_view<Ntk, false> : public fiction::static_depth_view<Ntk>
}

/**
* Rearranges the rank order of the PIs to the underlying PI order.
* This can be used to ensure equivalent PI order for equivalence checking.
* Rearranges the rank order of the PIs to match the underlying PI order defined by `static_depth_view`. This
* corresponds to the order in the network's `_storage`, which reflects the order of PI creation.
*
* This ensures a consistent PI order, which is essential for equivalence checking, as `mockturtle` relies on the PI
* order for this process.
*/
void rearrange_pis()
{