use System.CommandLine for coverlet.console #1486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcoRossignoli @daveMueller Please review and approve PR. |
test/coverlet.integration.tests/coverlet.integration.tests.csproj
Outdated
Show resolved
Hide resolved
test/coverlet.tests.xunit.extensions/coverlet.tests.xunit.extensions.csproj
Outdated
Show resolved
Hide resolved
|
@Bertk thanks a lot for this PR. Sorry for beeing super busy lately and not looking at it earlier. 🙏 |
|
@daveMueller Hi, could you please add your review result |
daveMueller
reviewed
Jun 11, 2023
Sorry I totally forgot to submit my review and it was pending the last 4 days. 🤦♂️ |
matches the same argument further down
|
@daveMueller can we merge this one? |
daveMueller
requested changes
Jul 30, 2023
There was a problem hiding this comment.
@MarcoRossignoli @Bertk Yes, just some nitpicks I want to be changed. Unfortunately I don't have the permission to change them on my own.
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Co-authored-by: David Müller <muellerdavid4@gmail.com>
Yes can be merged now. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1474