Make tests run on all platforms #1492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An extra space in the "coverlet " path and a platform specific directory separator char were the culprits for failing tests on Linux and macOS.
0xced
force-pushed
the
XPlatform-DotnetGlobalTools
branch
from
249e828 to
8bcff84
Compare
|
Cool 😲, thanks a lot @0xced 🙏 |
0xced
changed the title
|
/azp run |
|
No commit pushedDate could be found for PR 1492 in repo coverlet-coverage/coverlet |
MarcoRossignoli
approved these changes
Jul 23, 2023
MarcoRossignoli
pushed a commit
that referenced
this pull request
Aug 3, 2023
* use System.CommandLine for coverlet.console * resolve review comments and add DotnetTool tests * add space between CLI argument (#1499) matches the same argument further down * Fix resolving assemblies from frameworks not referenced by coverlet itself (#1449) * Make tests run on all platforms (#1492) * Integration test for assembly resolver for mvc.razor (#1502) * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * remove spelling configuration * use System.CommandLine for coverlet.console * resolve review comments and add DotnetTool tests * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * Update src/coverlet.console/Program.cs Co-authored-by: David Müller <muellerdavid4@gmail.com> * remove spelling configuration --------- Co-authored-by: David Markowitz <39972741+EmosewaMC@users.noreply.github.com> Co-authored-by: Lukas Grützmacher <44983012+lg2de@users.noreply.github.com> Co-authored-by: Cédric Luthi <cedric.luthi@gmail.com> Co-authored-by: David Müller <muellerdavid4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extra space in the "coverlet " path and a platform specific directory separator char were the culprits for failing the DotnetGlobalTools tests on Linux and macOS.