only run password-checks when the appropriate columns exist #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
@rndmh3ro thank you for the addition, once signed off, we can merge the PR
Signed-off-by: Sebastian Gumprich <github@gumpri.ch>
|
The previous implementation didn't work, because if there is a password-column in the user-table, it is totally possible that there is a authentication_string column, too. MySQL decides when to use which column based on the auth-plugin used. So now I changed the PR and just check if both columns are empty. If one of them is filled, it means there's a password used. If none is used, it's an empty password. @chris-rock, can you check again, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.