feat: implement canisterSubnet primitive
#4857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreif
added
feature
ggreif
commented
Jan 24, 2025
ggreif
force-pushed
the
gabor/canister-subnet
branch
4 times, most recently
from
6b7aa86 to
eb2dc94
Compare
ggreif
force-pushed
the
gabor/canister-subnet
branch
from
ccd2589 to
af7ac0b
Compare
ggreif
commented
Mar 14, 2025
ggreif
commented
Mar 14, 2025
ggreif
commented
Mar 14, 2025
nix/sources.json
Outdated
| @@ -26,10 +26,10 @@ | |||
| "homepage": "", | |||
| "owner": "luc-blaeser", | |||
| "repo": "ic", | |||
| "rev": "01c8dfda47126bb5f688302e0161f17c2c0cfe6f", | |||
| "sha256": "16h037xagxwf00k13y3h0gvfs7f3c45z2ml0j1pgvzg2fx5pzahy", | |||
| "rev": "ec8add504e63f97a2bc7f470d1b64dca550235af", | |||
There was a problem hiding this comment.
N.B.: I tried
$ git show origin/gabor/latest-drun
commit 12fec30a322fa5c39d97ea9385f2cdcaa22f6696 (origin/gabor/latest-drun)
Merge: d4820bfd4c 6e64281a8e
Author: Gabor Greif <gabor@dfinity.org>
Date: Tue Mar 11 09:37:32 2025 +0100
Merge tag 'release-2025-02-27_03-09-base' into gabor/latest-drun
too, but it generates strange cycle count failures.
ggreif
force-pushed
the
gabor/canister-subnet
branch
from
768b7ba to
1f32f4d
Compare
Kamirus
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
LGTM, but my expertise is still limited -- maybe @crusso or @luc-blaeser could take a look as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the primitive to get the current actor's subnet. Potentially the subnet the actor is residing in may change over time.
Depends-on dfinity/ic#3637. (On
main,but not labeled/proposed/adopted yet.)Needs https://github.com/dfinity/ic/releases/tag/release-2025-02-06_12-26-base in subnets
drunbumped for CI