Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ic to label release-2025-02-27_03-09-base #4951

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Mar 17, 2025

No description provided.

ggreif added 2 commits March 17, 2025 13:02
as build machines have plenty of space now, after cleaning out all the
irrelevant gunk
@ggreif ggreif requested a review from luc-blaeser March 17, 2025 12:42
@@ -50,12 +50,6 @@ jobs:

- run: nix-env -iA nix-build-uncached -f nix/

- name: "pre-build `drun`"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this any more

@@ -21,15 +21,15 @@
"version": "3.2.25"
},
"ic": {
"branch": "luc/latest-drun",
"branch": "gabor/latest-drun",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert this when all is reviewed

"description": "Internet Computer blockchain source: the client/replica software run by nodes",
"homepage": "",
"owner": "luc-blaeser",
"owner": "dfinity",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -1,4 +1,4 @@
ingress Completed: Reply: 0x4449444c016c01b3c4b1f204680100010a00000000000000000101
ingress Completed: Reply: 0x4449444c0000
debug.print: {heap_diff = 0; instr_diff = 5_240_635_753}
debug.print: {heap_diff = 0; instr_diff = 5_290_967_401}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you confirm these numbers in a local build on your machine?

git fetch
git switch gabor/ic-bump
git pull
nix-build -A tests.bench

Copy link
Contributor

@Kamirus Kamirus Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests failed:
region-mem.mo region0-mem.mo stable-mem.mo
make: *** [Makefile:4: all] Error 1
make: Leaving directory '/private/tmp/nix-build-test-bench.drv-0/test-bench-src/bench'
error: builder for '/nix/store/hv7pqri4xkvldbldy5ic8dg4cl5g5f6z-test-bench.drv' failed with exit code 2;
last 25 log lines:
> -debug.print: {heap_diff = 0; instr_diff = 5_290_967_401}
> +debug.print: {heap_diff = 0; instr_diff = 5_286_359_401}
> ingress Completed: Reply: 0x4449444c0000
> region0-mem: [tc] [comp] [valid] [drun-run]
> --- region0-mem.drun-run (expected)
> +++ region0-mem.drun-run (actual)
> @@ -1,4 +1,4 @@
> ingress Completed: Reply: 0x4449444c016c01b3c4b1f204680100010a00000000000000000101
> ingress Completed: Reply: 0x4449444c0000
> -debug.print: {heap_diff = 0; instr_diff = 5_718_786_409}
> +debug.print: {heap_diff = 0; instr_diff = 5_714_178_409}
> ingress Completed: Reply: 0x4449444c0000
> stable-mem: [tc] [comp] [valid] [drun-run]
> --- stable-mem.drun-run (expected)
> +++ stable-mem.drun-run (actual)
> @@ -1,4 +1,4 @@
> ingress Completed: Reply: 0x4449444c016c01b3c4b1f204680100010a00000000000000000101
> ingress Completed: Reply: 0x4449444c0000
> -debug.print: {heap_diff = 0; instr_diff = 3_932_012_905}
> +debug.print: {heap_diff = 0; instr_diff = 3_927_404_905}
> ingress Completed: Reply: 0x4449444c0000
> Some tests failed:
> region-mem.mo region0-mem.mo stable-mem.mo
> make: *** [Makefile:4: all] Error 1
> make: Leaving directory '/private/tmp/nix-build-test-bench.drv-0/test-bench-src/bench'
For full logs, run:
nix-store -l /nix/store/hv7pqri4xkvldbldy5ic8dg4cl5g5f6z-test-bench.drv

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-entered the nix-shell and now:

--- region-mem.drun-run (expected)
+++ region-mem.drun-run (actual)
@@ -1,4 +1,4 @@
 ingress Completed: Reply: 0x4449444c016c01b3c4b1f204680100010a00000000000000000101
 ingress Completed: Reply: 0x4449444c0000
-debug.print: {heap_diff = 0; instr_diff = 5_290_967_401}
+debug.print: {heap_diff = 0; instr_diff = 5_286_359_401}
 ingress Completed: Reply: 0x4449444c0000
region0-mem: [tc] [comp] [valid] [drun-run]
--- region0-mem.drun-run (expected)
+++ region0-mem.drun-run (actual)
@@ -1,4 +1,4 @@
 ingress Completed: Reply: 0x4449444c016c01b3c4b1f204680100010a00000000000000000101
 ingress Completed: Reply: 0x4449444c0000
-debug.print: {heap_diff = 0; instr_diff = 5_718_786_409}
+debug.print: {heap_diff = 0; instr_diff = 5_714_178_409}
 ingress Completed: Reply: 0x4449444c0000
stable-mem: [tc] [comp] [valid] [drun-run]
--- stable-mem.drun-run (expected)
+++ stable-mem.drun-run (actual)
@@ -1,4 +1,4 @@
 ingress Completed: Reply: 0x4449444c016c01b3c4b1f204680100010a00000000000000000101
 ingress Completed: Reply: 0x4449444c0000
-debug.print: {heap_diff = 0; instr_diff = 3_932_012_905}
+debug.print: {heap_diff = 0; instr_diff = 3_927_404_905}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants