Skip to content

Branch-merge bot does not work on aspnetcore-tooling due to files that exceed MAX_PATH #7882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
natemcmaster opened this issue Feb 22, 2019 · 4 comments
Closed

Branch-merge bot does not work on aspnetcore-tooling due to files that exceed MAX_PATH #7882

natemcmaster opened this issue Feb 22, 2019 · 4 comments
Assignees
@dougbu
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed task

Comments

@natemcmaster
Copy link
Contributor

The bot that merges release/* branches back to master does not work on https://github.com/aspnet/AspNetCore-Tooling because this repo contains files which exceed MAX_PATH.

error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/BindToComponent_EventCallback_SpecifiesValueAndExpression_Generic/TestComponent.mappings.txt: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/BindToComponent_EventCallback_SpecifiesValue_WithMatchingProperties/TestComponent.codegen.cs: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/BindToComponent_EventCallback_SpecifiesValue_WithMatchingProperties/TestComponent.mappings.txt: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/BindToComponent_SpecifiesValueAndChangeEvent_WithMatchingProperties/TestComponent.codegen.cs: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/BindToComponent_SpecifiesValueAndChangeEvent_WithMatchingProperties/TestComponent.mappings.txt: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/BindToComponent_SpecifiesValueAndChangeEvent_WithoutMatchingProperties/TestComponent.codegen.cs: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/BindToComponent_SpecifiesValueAndChangeEvent_WithoutMatchingProperties/TestComponent.mappings.txt: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/ChildComponent_WithGenericChildContent_SetsParameterNameOnComponent/TestComponent.codegen.cs: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/ChildComponent_WithGenericChildContent_SetsParameterNameOnComponent/TestComponent.mappings.txt: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/EventHandler_OnElement_ArbitraryEventName_WithEventArgsMethodGroup/TestComponent.mappings.txt: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentRuntimeCodeGenerationTest/BindToComponent_SpecifiesValueAndChangeEvent_WithoutMatchingProperties/TestComponent.codegen.cs: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentRuntimeCodeGenerationTest/BindToComponent_SpecifiesValueAndChangeEvent_WithoutMatchingProperties/TestComponent.mappings.txt: Filename too long

https://dev.azure.com/dnceng/internal/_build/results?buildId=104473

cc @dougbu @rynowak
@natemcmaster natemcmaster added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 22, 2019
@HaoK
Copy link
Member

HaoK commented Mar 6, 2019

Note this is also blocking these test files from being used on helix

@HaoK HaoK mentioned this issue Mar 6, 2019
Closed
@natemcmaster natemcmaster mentioned this issue Apr 15, 2019
Closed
dougbu added a commit to dotnet/razor that referenced this issue Apr 15, 2019
@dougbu
Shorten Microsoft.AspNetCore.Razor.Language.Test paths (#425)
72b939d 
* Shorten Microsoft.AspNetCore.Razor.Language.Test paths
- dotnet/aspnetcore#9358 and dotnet/aspnetcore#7882
- do 4046 renames
- adjust solutions to renamed directory
- special-case directory of the Microsoft.AspNetCore.Razor.Language.Test project in `TestProject`
@dougbu
Copy link
Contributor

dougbu commented Apr 15, 2019

72b939d85573

@dougbu dougbu closed this as completed Apr 15, 2019
@dougbu dougbu added the Done This issue has been fixed label Apr 15, 2019
@HaoK
Copy link
Member

HaoK commented Apr 15, 2019

@dougbu this max path issue also exists for https://github.com/aspnet/AspNetCore/tree/master/src/Mvc/Mvc.Api.Analyzers/test/TestFiles and https://github.com/aspnet/AspNetCore/tree/master/src/Mvc/Mvc.Analyzers/test/TestFiles which causes helix to reject these work items since the combined path is too long, do you think you can apply the same fix to those as well?

@dougbu
Copy link
Contributor

dougbu commented Apr 15, 2019

@HaoK if there's an issue, I can take it. Just assign it to me.

But, we shouldn't try to reuse this issue because it was about a related issue in the AspNetCore-Tooling repo.

@HaoK HaoK mentioned this issue Apr 16, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@danroth27 @natemcmaster @dougbu @HaoK