Skip to content

Shorten paths of Microsoft.AspNetCore.Razor.Language.Test files #9358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dougbu opened this issue Apr 14, 2019 · 6 comments
Closed

Shorten paths of Microsoft.AspNetCore.Razor.Language.Test files #9358

dougbu opened this issue Apr 14, 2019 · 6 comments
Assignees
@dougbu
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed feature-razor-pages

Comments

@dougbu
Copy link
Contributor

dougbu commented Apr 14, 2019

Bug

The paths of files in the ComponentDesignTimeCodeGenerationTest project are long enough to break dotnet-maestro-bot and prevent automatic PRs to merge 'release/*' branches into 'master'.

To Reproduce

Steps to reproduce the behavior:

  1. Merge a change into (say) 'release/3.0-preview4'
  2. Watch build jobs for the bot at https://dev.azure.com/dnceng/internal/_build?definitionId=350&_a=summary that relate to the aspnet/AspNetCore-Tooling repo

Expected behavior

Successful creation of a PR to merge the 'release/3.0-preview4' branch into 'master'

Actual

No PR to merge the branches is created. Bot builds such as https://dev.azure.com/dnceng/internal/_build/results?buildId=154762 fail to clone the aspnet/AspNetCore-Tooling repo due to filename-to-long errors:

error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/BindToComponent_EventCallback_SpecifiesValueAndExpression_Generic/TestComponent.mappings.txt: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/BindToComponent_EventCallback_SpecifiesValue_WithMatchingProperties/TestComponent.codegen.cs: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/BindToComponent_EventCallback_SpecifiesValue_WithMatchingProperties/TestComponent.mappings.txt: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/BindToComponent_SpecifiesValueAndChangeEvent_WithMatchingProperties/TestComponent.codegen.cs: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/BindToComponent_SpecifiesValueAndChangeEvent_WithMatchingProperties/TestComponent.mappings.txt: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/BindToComponent_SpecifiesValueAndChangeEvent_WithoutMatchingProperties/TestComponent.codegen.cs: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/BindToComponent_SpecifiesValueAndChangeEvent_WithoutMatchingProperties/TestComponent.mappings.txt: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/ChildComponent_WithGenericChildContent_SetsParameterNameOnComponent/TestComponent.codegen.cs: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/ChildComponent_WithGenericChildContent_SetsParameterNameOnComponent/TestComponent.mappings.txt: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentDesignTimeCodeGenerationTest/EventHandler_OnElement_ArbitraryEventName_WithEventArgsMethodGroup/TestComponent.mappings.txt: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentRuntimeCodeGenerationTest/BindToComponent_SpecifiesValueAndChangeEvent_WithoutMatchingProperties/TestComponent.codegen.cs: Filename too long
error: unable to create file src/Razor/test/Microsoft.AspNetCore.Razor.Language.Test/TestFiles/IntegrationTests/ComponentRuntimeCodeGenerationTest/BindToComponent_SpecifiesValueAndChangeEvent_WithoutMatchingProperties/TestComponent.mappings.txt: Filename too long

Additional context

See also dotnet/razor#422 (comment) and dotnet/razor#422 (comment) comments.

Thanks @dagood !
@dougbu dougbu added 2 - Working area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-razor-pages labels Apr 14, 2019
@dougbu dougbu self-assigned this Apr 14, 2019
@dougbu dougbu changed the title Shorten paths of ComponentDesignTimeCodeGenerationTest files Shorten paths of Microsoft.AspNetCore.Razor.Language.Test files Apr 14, 2019
dougbu added a commit to dotnet/razor that referenced this issue Apr 14, 2019
@dougbu
Shorten Microsoft.AspNetCore.Razor.Language.Test paths
9ad74ca 
- dotnet/aspnetcore#9358
dougbu added a commit to dotnet/razor that referenced this issue Apr 14, 2019
@dougbu
Shorten Microsoft.AspNetCore.Razor.Language.Test paths
cbea81b 
- dotnet/aspnetcore#9358
dougbu added a commit to dotnet/razor that referenced this issue Apr 14, 2019
@dougbu
Shorten Microsoft.AspNetCore.Razor.Language.Test paths …
e59030d 
- dotnet/aspnetcore#9358
- part 1 / 2 (renaming too many files for one PR)
dougbu added a commit to dotnet/razor that referenced this issue Apr 14, 2019
@dougbu
Shorten Microsoft.AspNetCore.Razor.Language.Test paths
87ab2bd 
- dotnet/aspnetcore#9358
- part 1 / 2 (renaming too many files to open a PR)
- adjust solutions to renamed directory
@dougbu dougbu mentioned this issue Apr 14, 2019
Merged
dougbu added a commit to dotnet/razor that referenced this issue Apr 14, 2019
@dougbu
Shorten Microsoft.AspNetCore.Razor.Language.Test paths
b8dcf9c 
- dotnet/aspnetcore#9358 (part 2 / 2)
- do 4046 renames
@natemcmaster
Copy link
Contributor

Duplicate of #7882?

@dagood
Copy link
Member

dagood commented Apr 15, 2019

Ha, yes.

@natemcmaster
Copy link
Contributor

Closing in favor of #7882.

dougbu added a commit to dotnet/razor that referenced this issue Apr 15, 2019
@dougbu
Shorten Microsoft.AspNetCore.Razor.Language.Test paths (#425)
72b939d 
* Shorten Microsoft.AspNetCore.Razor.Language.Test paths
- dotnet/aspnetcore#9358 and dotnet/aspnetcore#7882
- do 4046 renames
- adjust solutions to renamed directory
- special-case directory of the Microsoft.AspNetCore.Razor.Language.Test project in `TestProject`
@dougbu
Copy link
Contributor Author

dougbu commented Apr 15, 2019

72b939d85573

@pranavkm
Copy link
Contributor

@dougbu done?

@dougbu dougbu added Done This issue has been fixed and removed 2 - Working labels Apr 18, 2019
@dougbu
Copy link
Contributor Author

dougbu commented Apr 18, 2019

Yes, done

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed feature-razor-pages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pranavkm @natemcmaster @dougbu @dagood