Pass missing compiler parameters #45257
Conversation
Pass a few parameters to `<Csc>` that were missing and impact build reproducibility. closes #45256
dotnet-issue-labeler
bot
added
Area-ILLink
untriaged
|
Happy to take this immediately. For the future, is there a way between CoreCompile, Razor compile, and CoreGenerateSatelliteAssemblies that we can keep critical parameters in sync? |
|
Should this be targeting a release* branch? |
|
@Forgind we can always backport to 200 or something - it sounds like from #45256 (comment) there's not a huge correctness problem that might motivate going further back. |
|
I wasn't thinking we needed to go back further than 200; just seemed like since that's active development, may as well 🙂 |
|
/backport to release/9.02xx |
|
Started backporting to release/9.02xx: https://github.com/dotnet/sdk/actions/runs/12757300904 |
|
/backport to release/9.0.2xx |
|
Started backporting to release/9.0.2xx: https://github.com/dotnet/sdk/actions/runs/12757304371 |
|
@baronfel an error occurred while backporting to "release/9.02xx", please check the run log for details! Error: The specified backport target branch "release/9.02xx" wasn't found in the repo. |
Pass a few parameters to
<Csc>that were missing and impact build reproducibility.closes #45256