[release/9.0.2xx] Pass missing compiler parameters to satellite resource generation, making them deterministic #45938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Pass a few parameters to `<Csc>` that were missing and impact build reproducibility. closes #45256
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
baronfel
approved these changes
Jan 13, 2025
|
@marcpopMSFT are we still open for 9.0.200 at the SDK level? |
|
Any remaining changes should go through QB mode at this point. |
baronfel
changed the title
|
Approved over email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #45257 to release/9.0.2xx
These parameters negatively impact the reproducibility of the build and Jared says we should align them with other C# compiler invocations.
Description
This PR aligns the parameters passed to Csc when compiling satellite assemblies with other Csc invocations, and makes satellite assemblies deterministic where they weren't before.
Risk
Low - the practical effect of this will be that satellite assemblies are deterministic in the same way actual app assemblies are.
/cc @baronfel @jaredpar