Fix bad casting causing all entries to be unknown #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@laeubi can you please have a look? |
laeubi
requested changes
Jun 30, 2023
...se.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/preferences/LifecycleMappingsViewer.java
Outdated
Show resolved
Hide resolved
laeubi
requested changes
Jul 1, 2023
...se.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/preferences/LifecycleMappingsViewer.java
Show resolved
Hide resolved
...se.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/preferences/LifecycleMappingsViewer.java
Show resolved
Hide resolved
laeubi
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change made by 6eb17db#diff-28403ac299e4b874aaf674d927c7a0fa60fe79ea6fbfd07a5b827e51d84684e6L446 causes the Lifecycle Mappings preferences to show everything is "unknown" because
IPluginExecutionMetadataandLifecycleMappingMetadataSourcedo not share a common base class and thus could never beinstanceof.Current behavior as of 2.2.0:
Fix:
