Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad casting causing all entries to be unknown #1463

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Fix bad casting causing all entries to be unknown #1463

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58685c3
Fix bad casting causing all entries to be unknown
kysmith-csg Jun 29, 2023
af525be
Check casting type, extract labels to constants
kysmith-csg Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 54 additions & 18 deletions ...m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/preferences/LifecycleMappingsViewer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,37 @@

@SuppressWarnings("restriction")
public class LifecycleMappingsViewer {

/**
* Uninteresting lifecycle phase
*/
private static final String UNINTERESTING = "uninteresting"; //$NON-NLS-1$

/**
* Maven plugin lifecycle source
*/
private static final String MAVEN_PLUGIN = "maven-plugin"; //$NON-NLS-1$

/**
* Pom lifecycle source
*/
private static final String POM = "pom"; //$NON-NLS-1$

/**
* Eclipse extension lifecycle source
*/
private static final String EXTENSION = "extension"; //$NON-NLS-1$

/**
* Default execution source
*/
private static final String DEFAULT = "default"; //$NON-NLS-1$

/**
* Unknown lifecycle source
*/
private static final String UNKNOWN = "unknown"; //$NON-NLS-1$

/*package*/TreeViewer mappingsTreeViewer;

/*package*/boolean showPhases = false;
Expand All @@ -102,7 +133,7 @@ public class LifecycleMappingsViewer {
private IProject project;

void updateMappingsTreeViewer() {
if(mappingsTreeViewer == null) {
if(mappingsTreeViewer == null || mappingsTreeViewer.getControl().isDisposed()) {
return;
}
mappingsTreeViewer.refresh();
Expand Down Expand Up @@ -444,51 +475,56 @@ String getSourcelabel(MojoExecutionKey execution, List<IPluginExecutionMetadata>
LinkedHashSet<String> sources = new LinkedHashSet<>();
if(mappings != null && !mappings.isEmpty()) {
for(IPluginExecutionMetadata mapping : mappings) {
if(mapping instanceof LifecycleMappingMetadataSource metadata) {
Object source = metadata.getSource();
if(source instanceof String s) {
sources.add(s);
} else if(source instanceof Artifact artifact) {
sources.add(getSourceLabel(artifact, detailed));
} else if(source instanceof MavenProject mavenProject) {
sources.add(getSourceLabel(mavenProject, detailed));
} else if(source instanceof Bundle bundle) {
sources.add(getSourceLabel(bundle, detailed));
if(mapping instanceof PluginExecutionMetadata metadata) {
LifecycleMappingMetadataSource metadataSource = metadata.getSource();
if(metadataSource == null) {
sources.add(UNKNOWN);
} else {
sources.add("unknown"); //$NON-NLS-1$
Object source = metadataSource.getSource();
if(source instanceof String s) {
sources.add(s);
} else if(source instanceof Artifact artifact) {
sources.add(getSourceLabel(artifact, detailed));
} else if(source instanceof MavenProject mavenProject) {
sources.add(getSourceLabel(mavenProject, detailed));
} else if(source instanceof Bundle bundle) {
sources.add(getSourceLabel(bundle, detailed));
} else {
sources.add(UNKNOWN); //$NON-NLS-1$
}
}
} else if(mapping instanceof DefaultPluginExecutionMetadata) {
sources.add("default"); //$NON-NLS-1$
sources.add(DEFAULT); //$NON-NLS-1$
} else {
sources.add("unknown"); //$NON-NLS-1$
sources.add(UNKNOWN); //$NON-NLS-1$
}
}
} else {
if(!LifecycleMappingFactory.isInterestingPhase(execution.lifecyclePhase())) {
sources.add("uninteresting"); //$NON-NLS-1$
sources.add(UNINTERESTING); //$NON-NLS-1$
}
}
return String.join(", ", sources);
}

private String getSourceLabel(Bundle bundle, boolean detailed) {
StringBuilder sb = new StringBuilder("extension"); //$NON-NLS-1$
StringBuilder sb = new StringBuilder(EXTENSION); //$NON-NLS-1$
if(detailed) {
sb.append('(').append(bundle.getSymbolicName()).append('_').append(bundle.getVersion()).append(')');
}
return sb.toString();
}

private String getSourceLabel(MavenProject project, boolean detailed) {
StringBuilder sb = new StringBuilder("pom"); //$NON-NLS-1$
StringBuilder sb = new StringBuilder(POM); //$NON-NLS-1$
if(detailed) {
sb.append('(').append(project.toString()).append(')');
}
return sb.toString();
}

private String getSourceLabel(Artifact plugin, boolean detailed) {
StringBuilder sb = new StringBuilder("maven-plugin"); //$NON-NLS-1$
StringBuilder sb = new StringBuilder(MAVEN_PLUGIN); //$NON-NLS-1$
if(detailed) {
sb.append('(').append(plugin.toString()).append(')');
}
Expand Down