Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Couchbase Columnar as an Offline Store #5025

Merged
merged 22 commits into from
Feb 28, 2025
Merged

feat: Add Couchbase Columnar as an Offline Store #5025

merged 22 commits into from
Feb 28, 2025

Conversation

ejscribner
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

N/A

Misc

@ejscribner ejscribner requested a review from a team as a code owner February 6, 2025 23:09
@ejscribner ejscribner force-pushed the couchbase-offline-store branch 6 times, most recently from 35e23e9 to 64f2616 Compare February 7, 2025 20:56
@ejscribner ejscribner force-pushed the couchbase-offline-store branch from 64f2616 to 655f2d1 Compare February 11, 2025 01:11
@ejscribner ejscribner force-pushed the couchbase-offline-store branch 2 times, most recently from 6bdb721 to 583defd Compare February 18, 2025 19:34
ntkathole
ntkathole reviewed Feb 26, 2025
View reviewed changes
setup.py
COUCHBASE_REQUIRED = ["couchbase==4.3.2"]
COUCHBASE_REQUIRED = [
"couchbase==4.3.2",
"couchbase-columnar==1.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this in https://github.com/feast-dev/feast/blob/master/pyproject.toml#L58 as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added: 645467b

@ejscribner ejscribner force-pushed the couchbase-offline-store branch from dc1a10b to d23a582 Compare February 26, 2025 16:22
@ejscribner
Add Couchbase Columnar and Sync Deps
db77c7e 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Couchbase Columnar Offline Store
9930c72 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Testing Config
c6d16fb 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Warnings for Experimental Store
c14574e 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Initial Template
fa34d15 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Temp Timeout Fix and Lint
e27202e 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Initial Docs
21b78c9 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Fixing Template
78d780e 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Protos
8b7bbf1 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Make build-sphinx
265fda5 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Add info on Columnar setup to docs
d9f749d 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Docs Adjustment
6e0c777 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Lint Fix
a4e1425 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Dispatch Timeouts
ef34493 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Cleanup Steps for Test Resources
37791a8 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Remove unneccesary cleanup util file
fcdfa0f 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Refactor couchbase to couchbase.offline
3e11eec 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Refactor couchbase online literal to couchbase.online
0cb77ae 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Test cleanup
c038560 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Added couchbase.offline to operator types
623c1a1 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Add Couchbase to Roadmap for Offline, Online, and Data Source
266302e 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner
Add couchbase-columnar to pyproject.toml
4df968b 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
@ejscribner ejscribner force-pushed the couchbase-offline-store branch from 645467b to 4df968b Compare February 27, 2025 16:55
franciscojavierarceo
franciscojavierarceo approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great @ejscribner!! 🚀

@franciscojavierarceo franciscojavierarceo merged commit 4373cbf into feast-dev:master Feb 28, 2025
24 checks passed
franciscojavierarceo pushed a commit that referenced this pull request Mar 10, 2025
@feast-ci-bot
chore(release): release 0.47.0
3e3afa9 
# [0.47.0](v0.46.0...v0.47.0) (2025-03-10)

* feat!: Include PUBLIC_URL in defaultProjectListPromise URL in /ui ([2f0f7b3](2f0f7b3))

### Bug Fixes

* Add transformation_service_endpoit to support Go feature server. ([#5071](#5071)) ([5627d7c](5627d7c))
* Adding extra space on the VM to kind cluster to see if this solves the issue with memory not available with operator e2e tests. ([#5102](#5102)) ([e6e928c](e6e928c))
* Allow unencrypted Snowflake key ([#5097](#5097)) ([87a7c23](87a7c23))
* Cant add different type of list types ([#5118](#5118)) ([bebd7be](bebd7be))
* Fixing transformations on writes ([#5127](#5127)) ([95ac34a](95ac34a))
* Identify s3/remote uri path correctly ([#5076](#5076)) ([93becff](93becff))
* Increase available action VM storage and reduce dev feature-server image size ([#5112](#5112)) ([75f5a90](75f5a90))
* Move Feast to pyproject.toml instead of setup.py ([#5067](#5067)) ([4231274](4231274))
* Skip refresh if already in progress or if lock is already held ([#5068](#5068)) ([f3a24de](f3a24de))

### Features

* Add an OOTB Chat uI to the Feature Server to support RAG demo ([#5106](#5106)) ([40ea7a9](40ea7a9))
* Add Couchbase Columnar as an Offline Store ([#5025](#5025)) ([4373cbf](4373cbf))
* Add Feast Operator RBAC example with Kubernetes Authentication … ([#5077](#5077)) ([2179fbe](2179fbe))
* Added docling and pytorch as add on ([#5089](#5089)) ([135342b](135342b))
* Feast Operator example with Postgres in TLS mode. ([#5028](#5028)) ([2c46f6a](2c46f6a))
* Operator - Add feastProjectDir section to CR with git & init options ([#5079](#5079)) ([d64f01e](d64f01e))
* Override the udf name when provided as input to an on demand transformation ([#5094](#5094)) ([8a714bb](8a714bb))
* Set value_type of entity directly in from_proto ([#5092](#5092)) ([90e7498](90e7498))
* Updating retrieve online documents v2 to work for other fields for sq… ([#5082](#5082)) ([fc121c3](fc121c3))

### BREAKING CHANGES

* The PUBLIC_URL environment variable is now taken into account by default
when fetching the projects list. This is a breaking change only if all
these points apply:

1. You're using Feast UI as a module

2. You're serving the UI files from a non-root path via the PUBLIC_URL
   environment variable

3. You're serving the project list from the root path

4. You're not passing the `feastUIConfigs.projectListPromise` prop to
   the FeastUI component

In this case, you need to explicitly fetch the project list from the
root path via the `feastUIConfigs.projectListPromise` prop:

```diff
 const root = createRoot(document.getElementById("root")!);
 root.render(
   <React.StrictMode>
-    <FeastUI />
+    <FeastUI
+      feastUIConfigs={{
+        projectListPromise: fetch("/projects-list.json", {
+            headers: {
+              "Content-Type": "application/json",
+            },
+          }).then((res) => res.json())
+      }}
+    />
   </React.StrictMode>
 );
```

Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntkathole ntkathole ntkathole left review comments

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ejscribner @franciscojavierarceo @ntkathole