Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase available action VM storage and reduce dev feature-server image size #5112

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

tchughesiv
Copy link
Contributor

@tchughesiv tchughesiv commented Mar 3, 2025

What this PR does / why we need it:

Cleans up unused ubuntu installations, switches kind container dir to use /mnt, and only copies specific folders during feature-server image build. This PR also skips additional image builds for later tests. Only one image build is necessary for the operator and feature-server, respectively.

Which issue(s) this PR fixes:

Fixes #5108

Misc

reverts some of the changes made in #5089

recent addition of pytorch appears problematic ... adding at least 755mb

Downloading torch-2.2.2-cp311-cp311-manylinux1_x86_64.whl (755.6 MB)

@tchughesiv tchughesiv changed the title Dev img fix: Reduce dev feature-server image Mar 3, 2025
@tchughesiv tchughesiv changed the title fix: Reduce dev feature-server image fix: Reduce dev feature-server image size Mar 3, 2025
@tchughesiv tchughesiv marked this pull request as ready for review March 3, 2025 20:39
@tchughesiv tchughesiv requested a review from a team as a code owner March 3, 2025 20:39
Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@franciscojavierarceo
Copy link
Member

disk space issues, want me to merge anyway?

@tchughesiv tchughesiv marked this pull request as draft March 3, 2025 21:51
@tchughesiv
Copy link
Contributor Author

@franciscojavierarceo not yet ... trying some more things

@tchughesiv tchughesiv changed the title fix: Reduce dev feature-server image size fix: Increase available action VM storage and reduce dev feature-server image size Mar 4, 2025
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
@tchughesiv tchughesiv marked this pull request as ready for review March 4, 2025 02:14
Copy link
Contributor

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@franciscojavierarceo franciscojavierarceo merged commit 75f5a90 into feast-dev:master Mar 4, 2025
25 checks passed
franciscojavierarceo pushed a commit that referenced this pull request Mar 10, 2025
# [0.47.0](v0.46.0...v0.47.0) (2025-03-10)

* feat!: Include PUBLIC_URL in defaultProjectListPromise URL in /ui ([2f0f7b3](2f0f7b3))

### Bug Fixes

* Add transformation_service_endpoit to support Go feature server. ([#5071](#5071)) ([5627d7c](5627d7c))
* Adding extra space on the VM to kind cluster to see if this solves the issue with memory not available with operator e2e tests. ([#5102](#5102)) ([e6e928c](e6e928c))
* Allow unencrypted Snowflake key ([#5097](#5097)) ([87a7c23](87a7c23))
* Cant add different type of list types ([#5118](#5118)) ([bebd7be](bebd7be))
* Fixing transformations on writes ([#5127](#5127)) ([95ac34a](95ac34a))
* Identify s3/remote uri path correctly ([#5076](#5076)) ([93becff](93becff))
* Increase available action VM storage and reduce dev feature-server image size ([#5112](#5112)) ([75f5a90](75f5a90))
* Move Feast to pyproject.toml instead of setup.py ([#5067](#5067)) ([4231274](4231274))
* Skip refresh if already in progress or if lock is already held ([#5068](#5068)) ([f3a24de](f3a24de))

### Features

* Add an OOTB Chat uI to the Feature Server to support RAG demo ([#5106](#5106)) ([40ea7a9](40ea7a9))
* Add Couchbase Columnar as an Offline Store ([#5025](#5025)) ([4373cbf](4373cbf))
* Add Feast Operator RBAC example with Kubernetes Authentication … ([#5077](#5077)) ([2179fbe](2179fbe))
* Added docling and pytorch as add on ([#5089](#5089)) ([135342b](135342b))
* Feast Operator example with Postgres in TLS mode. ([#5028](#5028)) ([2c46f6a](2c46f6a))
* Operator - Add feastProjectDir section to CR with git & init options ([#5079](#5079)) ([d64f01e](d64f01e))
* Override the udf name when provided as input to an on demand transformation ([#5094](#5094)) ([8a714bb](8a714bb))
* Set value_type of entity directly in from_proto ([#5092](#5092)) ([90e7498](90e7498))
* Updating retrieve online documents v2 to work for other fields for sq… ([#5082](#5082)) ([fc121c3](fc121c3))

### BREAKING CHANGES

* The PUBLIC_URL environment variable is now taken into account by default
when fetching the projects list. This is a breaking change only if all
these points apply:

1. You're using Feast UI as a module

2. You're serving the UI files from a non-root path via the PUBLIC_URL
   environment variable

3. You're serving the project list from the root path

4. You're not passing the `feastUIConfigs.projectListPromise` prop to
   the FeastUI component

In this case, you need to explicitly fetch the project list from the
root path via the `feastUIConfigs.projectListPromise` prop:

```diff
 const root = createRoot(document.getElementById("root")!);
 root.render(
   <React.StrictMode>
-    <FeastUI />
+    <FeastUI
+      feastUIConfigs={{
+        projectListPromise: fetch("/projects-list.json", {
+            headers: {
+              "Content-Type": "application/json",
+            },
+          }).then((res) => res.json())
+      }}
+    />
   </React.StrictMode>
 );
```

Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev Images are failing to build
3 participants