Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a semicolon in CMAKE_Fortran_FLAGS when additional flags are passed to cmake #334

Merged

Conversation

branfosj
Copy link
Contributor

Name and Institution (Required)

Name: Simon Branford
Institution: University of Birmingham

Confirm you have reviewed the following documentation

Describe the update

This fixes the setting of CMAKE_Fortran_FLAGS in the case where a user wishes to specify additional flags.

In #326 the extra flag was -m64 for me it was -march=native.

git clone https://github.com/geoschem/GCHP.git
cd GCHP
git checkout 14.1.1
git submodule update --init --recursive
mkdir build & cd build
cmake -DCMAKE_Fortran_FLAGS="-march=native" ../
make VERBOSE=1

Expected changes

GCHP to successfully build if there are extra flags passed to cmake via CMAKE_Fortran_FLAGS.

Reference(s)

None

Related Github Issue(s)

#326

@yantosca yantosca added topic: Build Related to makefiles or the build sequence never stale Never label this issue as stale bugfix labels Aug 1, 2023
@msulprizio msulprizio changed the base branch from main to dev/no-diff-to-benchmark October 25, 2023 16:33
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge

@yantosca yantosca linked an issue Dec 13, 2023 that may be closed by this pull request
4 tasks
@yantosca
Copy link
Contributor

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCHP      #7b7bfa3 PR #334 post-merge update: Edit CHANGELOG.md
GEOS-Chem #69ae58a1b Merge PR #2069 (Reduce timers to essential list only)
HEMCO     #a5d5169 HEMCO 3.7.2 release

Number of execution tests: 5

Submitted as SLURM job: 12586816
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also all GCHP integration tests were identical to 14.2.3.

@yantosca yantosca merged commit 24c5eed into geoschem:dev/no-diff-to-benchmark Dec 13, 2023
yantosca added a commit that referenced this pull request Dec 13, 2023
CHANGELOG.md
- Added note about the update to avoid a semicolon when passing
  additional flags to CMake

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added this to the 14.3.0 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
never stale Never label this issue as stale topic: Build Related to makefiles or the build sequence
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCHP 14.1.1 Compilation Error
2 participants