Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge no-diff-to-benchmark updates into the 14.3.0 development stream #365

Merged
merged 10 commits into from
Jan 8, 2024

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Jan 5, 2024

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Confirm you have reviewed the following documentation

Describe the update

This PR requests to merge the dev/no-diff-to-benchmark branch into the dev/14.3.0 branch. This includes updates from the following PRs:

Hashes will be updated for the various PRs described in

Expected changes

All of these updates have been verified to be zero-diff w/r/t the fullchem benchmark simulation vs GEOS-Chem 14.2.3.

branfosj and others added 10 commits July 26, 2023 13:14
…s.H)

This commit informs the GCHP superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

60c682c32 Merge PR #2061 (Add missing units in commonIncludeVars.H)

This updates comments in KPP/fulllchem/commonIncludeVars.H with
the proper units of each quantity.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This commit informs the GCHP superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

c98fcce0a Merge PR #2059 (Now read Hg restarts from v2023-12 folder)

This adds an update for the Hg simulation to use well-spun-up initial
conditions from ExtData/GEOSCHEM_RESTARTS/v2023-12.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This commit informs the GCHP superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

69ae58a1b Merge PR #2069 (Reduce timers to essential list only)

PR #2069 removes several GEOS-Chem Classic timers that were not being
used for benchmark statistics.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This merge brings PR #334 (Avoid a semicolon in CMAKE_Fortran_FLAGS when
additional flags are passed to cmake, by @branfosj) into the GEOS-Chem
"no-diff-to-benchmark" development stream.

This fixes an error in the CMake compilation command when additional
flags are passed to cmake.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
CHANGELOG.md
- Added note about the update to avoid a semicolon when passing
  additional flags to CMake

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This merge informs the GCHP superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

c5dca3a84 Merge PR #2058 (GEOS-Chem Transport Tracers simulation GEOS)

PR #2058 adds several updates necessary to run the TransportTracers
simulation in the GEOS model.  It will not affect GCClassic or GCHP
simulations.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This commit informs the GCHP superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

be203a9d9 Merge PR #2084 (Use rundir to generate executable file name in tests)

This PR fixes an issue in integration tests that caused the wrong
executable file to be placed in rundirs.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
…sts)

This commit informs the GCHP superproject about the following
commits that were pushed to the GitHub geoschem/geos-chem repository:

def47a064 Merge PR #2095 (Update time limits for GCHP integration tests)

This increases the requested time for GCHP integration tests in order
to better prevent the tests timing out in computational queues.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This commit informs the GCHP superproject about the following
commits that were pushed from the GitHub geoschem/geos-chem repository:

aad13ea0a Merge PR #2062 (Updates from GMAO for GEOS)

This adds updates specific to running GEOS-Chem in the NASA GEOS ESM.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added the no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations label Jan 5, 2024
@yantosca yantosca requested a review from msulprizio January 5, 2024 19:48
@msulprizio msulprizio merged commit faea873 into dev/14.3.0 Jan 8, 2024
@msulprizio msulprizio added this to the 14.3.0 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants