-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge no-diff-to-benchmark updates into the 14.3.0 development stream #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.H) This commit informs the GCHP superproject about the following commits that were pushed to the GitHub geoschem/geos-chem repository: 60c682c32 Merge PR #2061 (Add missing units in commonIncludeVars.H) This updates comments in KPP/fulllchem/commonIncludeVars.H with the proper units of each quantity. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This commit informs the GCHP superproject about the following commits that were pushed to the GitHub geoschem/geos-chem repository: c98fcce0a Merge PR #2059 (Now read Hg restarts from v2023-12 folder) This adds an update for the Hg simulation to use well-spun-up initial conditions from ExtData/GEOSCHEM_RESTARTS/v2023-12. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This commit informs the GCHP superproject about the following commits that were pushed to the GitHub geoschem/geos-chem repository: 69ae58a1b Merge PR #2069 (Reduce timers to essential list only) PR #2069 removes several GEOS-Chem Classic timers that were not being used for benchmark statistics. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This merge brings PR #334 (Avoid a semicolon in CMAKE_Fortran_FLAGS when additional flags are passed to cmake, by @branfosj) into the GEOS-Chem "no-diff-to-benchmark" development stream. This fixes an error in the CMake compilation command when additional flags are passed to cmake. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
CHANGELOG.md - Added note about the update to avoid a semicolon when passing additional flags to CMake Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This merge informs the GCHP superproject about the following commits that were pushed to the GitHub geoschem/geos-chem repository: c5dca3a84 Merge PR #2058 (GEOS-Chem Transport Tracers simulation GEOS) PR #2058 adds several updates necessary to run the TransportTracers simulation in the GEOS model. It will not affect GCClassic or GCHP simulations. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This commit informs the GCHP superproject about the following commits that were pushed to the GitHub geoschem/geos-chem repository: be203a9d9 Merge PR #2084 (Use rundir to generate executable file name in tests) This PR fixes an issue in integration tests that caused the wrong executable file to be placed in rundirs. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
…sts) This commit informs the GCHP superproject about the following commits that were pushed to the GitHub geoschem/geos-chem repository: def47a064 Merge PR #2095 (Update time limits for GCHP integration tests) This increases the requested time for GCHP integration tests in order to better prevent the tests timing out in computational queues. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This commit informs the GCHP superproject about the following commits that were pushed from the GitHub geoschem/geos-chem repository: aad13ea0a Merge PR #2062 (Updates from GMAO for GEOS) This adds updates specific to running GEOS-Chem in the NASA GEOS ESM. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
msulprizio
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no-diff-to-benchmark
This update will not change the results of fullchem benchmark simulations
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
This PR requests to merge the dev/no-diff-to-benchmark branch into the dev/14.3.0 branch. This includes updates from the following PRs:
cmake
#334Hashes will be updated for the various PRs described in
Expected changes
All of these updates have been verified to be zero-diff w/r/t the fullchem benchmark simulation vs GEOS-Chem 14.2.3.