Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache image replacement doesn't work with base-builder-go. #890

Closed
oliverchang opened this issue Mar 18, 2025 · 1 comment · Fixed by #892
Closed

Cache image replacement doesn't work with base-builder-go. #890

oliverchang opened this issue Mar 18, 2025 · 1 comment · Fixed by #892
Assignees
@oliverchang
Labels
bug Something isn't working

Comments

@oliverchang
Copy link
Collaborator

Looks like the current cache image replacement doesn't take into account variants of the base-builder image.

#3 [internal] load metadata for us-central1-docker.pkg.dev/oss-fuzz/oss-fuzz-gen/boringssl-ofg-cached-address-go:latest
#3 ERROR: us-central1-docker.pkg.dev/oss-fuzz/oss-fuzz-gen/boringssl-ofg-cached-address-go:latest: not found
------
 > [internal] load metadata for us-central1-docker.pkg.dev/oss-fuzz/oss-fuzz-gen/boringssl-ofg-cached-address-go:latest:
@oliverchang oliverchang added the bug Something isn't working label Mar 18, 2025
@DonggeLiu
Copy link
Collaborator

Root cause:

oss-fuzz-gen/experiment/oss_fuzz_checkout.py

Line 375 in 0ffbfca

'FROM gcr.io/oss-fuzz-base/base-builder', f'FROM {cached_image_name}')

Dockerfile of boringssl:
https://github.com/google/oss-fuzz/blob/c6ba21556d651db6c770cb3f092793b88c4b2b61/projects/boringssl/Dockerfile#L17

@oliverchang oliverchang mentioned this issue Mar 18, 2025
Merged
oliverchang added a commit that referenced this issue Mar 18, 2025
@oliverchang
Unify cache (#892)
09c3799 
We had 2 very similar but slightly different functions for using cached
oss-fuzz images.

There were some behaviour differences also (e.g. not copying the build
script as well as the fuzz target in the
`rewrite_project_to_cached_project_chronos` function).

Also fix #890 while we're here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverchang oliverchang

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify cache google/oss-fuzz-gen
3 participants
@DavidKorczynski @oliverchang @DonggeLiu