Unify cache #892
Merged
Unify cache #892
+27
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had 2 very similar but slightly different functions for using cached oss-fuzz images.
oliverchang
commented
Mar 18, 2025
| @@ -0,0 +1,81 @@ | |||
| "functions": | |||
There was a problem hiding this comment.
this is temporary, to test this works.
|
/gcbrun exp -n oc -ag |
DonggeLiu
approved these changes
Mar 18, 2025
oliverchang
added a commit
that referenced
this pull request
Mar 18, 2025
|
https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2025-03-18-892-oc-comparison/index.html looks good, and boringssl now has workng builds. |
DavidKorczynski
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had 2 very similar but slightly different functions for using cached oss-fuzz images.
There were some behaviour differences also (e.g. not copying the build script as well as the fuzz target in the
rewrite_project_to_cached_project_chronosfunction).Also fix #890 while we're here.