Adding Covariance Matrices #715
Conversation
|
The last two commits addressed a few bugs that I came across while using these in some fits. DerivedParams are a bit closer to serializability now |
|
This looks great! So the old parameters still are usable from within each stage as if nothing happened, but internally they are represented in the rotated form, if I understood correctly? |
That's right! It essentially turns the two Params into four. The original ones are replaced with |
|
Cool! Is this PR thought as WIP, or do you want to get what you have merged? |
|
I'd like what I have here merged! |
|
cool! I then only want to run a few checks and if they pass merge it |
|
Run come additional checks, it all looks good and will merge now |
* code for setting up de-correlated params * implementing cov in pipelines and distrib_makers * handled slots, changed dependson structure * function magic to ensure each parameter is set * added test for covariance * added code for serializing functions * changed some typing hints * more Param-like for interfacing with Param funcs * bug fix, added extra error-checking * serialization for DerivedParms; needed by fits
Basic functionality is here - hoping to continue work on this on a branch in the IceCube PISA repo rather than my personal fork.
What's here, now
What's not yet fully there
DerivedParams and defining functions in config filesDerivedParams