Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These commits will allow
DerivedParam
s to be defined in thecfg
files directly. Much of this is relevant to additions in pull request #715This is very handy if you have a basis change for your nuisance parameters, and don't need as many parameters in the new basis to span the space of all output shapes accessible.
Additions
Edits here are pretty minor. I just added some lines to the
config_parser
to make theDerivedParam
s and configure them appropriately. I also made a minor change to theStage
class so it doesn't raise exceptions when a bunch of extra parameters are there. I removed a print statement too.Usage
For a
DerivedParam
, a list of parameter names theDerivedParam
is derived from needs to be provided, separated by spaces; this is assigned todepends_names
.It should also be passed a
function_file
, which is a pisa-path (or full path) pointing to a json-serialized utils.callable.Funct whose relevantVar
s refer to thoseParam
names theDerivedParam
depends on.Ex:
So, for example, you could have
Param
s theta_34 and theta_24, andDerivedParam
s for U_mu4 and U_tau4 which load function files telling it how to calculate the unitary mixing matrix elements from the mixing angles themselves (or you could do the exact opposite).