-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array img opt neighborhoods-Leon's branch #395
base: master
Are you sure you want to change the base?
Conversation
This allows implementations to work on only some specific shapes.
Since MapNeighborhood inherently works with OOBF, an optional parameter is added, and is only used when it is not null.
Now that this op has much higher priority than DefaultMapNeighborhood, more implementations of MapNeighborhood could fit between the two.
@Squareys can you have a look please? One remark which I also discussed with @Squareys back then: We have to make sure that we don't introduce any new behaviour. I mean: we only want to merge this branch if the behaviour of |
The The In short: This complies with existing behaviour. I hope this clears some confusion. @LeonYang5114 The changes look great, thank you for taking care of this! There are a few formatting commits mixed with actual changes in the WIP commits, but I guess that will be taken care of once the history is rewritten. |
Signed-off-by: squareys <squareys@googlemail.com>
Signed-off-by: squareys <squareys@googlemail.com>
01196ad
to
2b03ab2
Compare
Since I am not very familiar with the original commits, I made two big rebases to rewrite the history, one for implementation and one for test. @Squareys if you have time, feel free to split the commit and add more detailed commit message. If you think it is OK, then this branch is ready for merging. |
This is a branch built on top of @Squareys and @ctrueden 's work. See #191
The first 4 commits modify the existing interfaces of
MapNeighborhood
, so that the following commits could work. Basically it makes theShape
parameter generic, and add an optionalOOBF
to both default and center-aware implementations.Some modifications are rebased into the middle commits, so that the
OpEnvironment
always compile.My last four commits change the structure of @Squareys 's implementation a little bit, so that those
NativeType
versions are actuallyMapNeighborhood
ops, instead justMapOp
s. I also made some small fixes. See the commit message for more information.This branch is not ready for merging, because the history is messy (although all the tests are passing now). @Squareys @ctrueden Please have a look and clean up the history as you want.