fix💥: don't pass kwargs to modal callbacks #1584
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes interactions-py#1517, but is breaking.
eightween
added
enhancement
AstreaTSS
added a commit
to AstreaTSS/interactions-py-library
that referenced
this pull request
Feb 21, 2024
13 tasks
|
Closing as #1619 supersedes this as a non-breaking change. That being said, this should be done at some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This PR fixes #1517 by making sure
ctx.kwargsis not passed into modal callbacks. While this behavior was unintended, this change is breaking, hence the draft status.Changes
call_callbackinModalCommandso that the actual callback does not receive**ctx.kwargs.Related Issues
Fixes #1517.
Test Scenarios
See bug report.
Python Compatibility
3.10.x3.11.xChecklist
pre-commitcode linter over all edited files