fix: don't pass kwargs to modal callbacks that only have ctx #1619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This PR fixes #1517 by making sure
ctx.kwargs
is not passed into modal callbacks. Unlike #1584, this PR only does so if the only argument in the modal callback isctx
(andself
).Changes
ModalCommand
to note if the callback just hasctx
or has more parameters at play.ctx
andself
. If there are no parameters, enable the above attribute.ModalCommand
pass in no kwargs if the attribute is enabled.Related Issues
Fixes #1517. A non-breaking, superseding alternative to #1584.
Test Scenarios
See #1517 for an example.
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files