Skip to content

Breaking change for file paths in recent npm compatibility update #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
donovanglover opened this issue May 2, 2024 · 5 comments · Fixed by #493
Closed

Breaking change for file paths in recent npm compatibility update #477

donovanglover opened this issue May 2, 2024 · 5 comments · Fixed by #493

Comments

@donovanglover
Copy link

The recent PR #463 causes __dirname to include ./_dist, breaking packages that depend on files relative to __dirname.

For example, join(__dirname, '../schemes') will resolve to ./schemes in _jsr_revision 8 and ./_dist/schemes in 10.

Related: #462
@github-project-automation github-project-automation bot moved this to Needs Triage in JSR May 2, 2024
@lucacasonato
Copy link
Member

How are you doing this in the first place? __dirname does not exist in ESM.

@marvinhagemeister
Copy link
Contributor

Maybe through import.meta.dirname?

@donovanglover
Copy link
Author

Will try making a new release later today with import.meta.dirname. Had to add "type": "module" to package.json and add a mock for ts-jest.

@lucacasonato
Copy link
Member

I think you'll run into the same issue - I'll look into if there is anything we can do here to fix this

This was referenced May 8, 2024
Open
Merged
@lucacasonato
Copy link
Member

@donovanglover We're going to update the emit to emit the .js files next to the .ts files directly, and only place the .d.ts files in a separate _dist folder.

github-merge-queue bot pushed a commit that referenced this issue May 8, 2024
@lucacasonato
fix: improve npm tarball emit (#493)
7e28877 
Some relative specifiers were being incorrectly emitted when referencing
a `.js`
file from a `.d.ts` file in the dist folder.

Additionally, `.js` files were previously emitted into a `_dist` folder,
which
broke users that need to relatively access files in the NPM package
using
`import.meta.url` or similar. Now only `.d.ts` files are emitted into
the
`_dist` folder.

Fixes #491
Fixes #477
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in JSR May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
JSR
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve npm tarball emit jsr-io/jsr
3 participants
@marvinhagemeister @donovanglover @lucacasonato