fix: improve npm tarball emit #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some relative specifiers were being incorrectly emitted when referencing a `.js` file from a `.d.ts` file in the dist folder. Additionally, `.js` files were previously emitted into a `_dist` folder, which broke users that need to relatively access files in the NPM package using `import.meta.url` or similar. Now only `.d.ts` files are emitted into the `_dist` folder.
lucacasonato
commented
May 8, 2024
api/src/npm/specifiers.rs
Outdated
| let new_specifier = if resolved_specifier.scheme() == "file" { | ||
| relative_import_specifier(self.base_specifier, &resolved_specifier) | ||
| } else { | ||
| resolved_specifier.to_string() | ||
| }; | ||
|
|
||
| if &new_specifier == source_text_specifier { |
There was a problem hiding this comment.
This was happening in the wrong place. If we need to update the specifier because the base specifier is different, we still need to write the updated specifier.
marvinhagemeister
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some relative specifiers were being incorrectly emitted when referencing a
.jsfile from a
.d.tsfile in the dist folder.Additionally,
.jsfiles were previously emitted into a_distfolder, whichbroke users that need to relatively access files in the NPM package using
import.meta.urlor similar. Now only.d.tsfiles are emitted into the_distfolder.Fixes #491
Fixes #477