Skip to content

[LowerToHW] Remove PRINTF_FD macro #8432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented Apr 22, 2025

As fprintf implemented more enhanced feature for fine-grained logging
the commit removes PRINTF_FD macro

As fprintf implemented more enhanced feature for fine-grained logging
the commit removes PRINTF_FD macro
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FYI: @sequencer

@sequencer
Copy link
Contributor

Thanks!
Please wait until we land 1.114.0 these two days.
After we got 1.114.0, we will do the printf migration immediately.
We may take 1~2 days for migration.
If there are no issues for the migration(I didn't see any possible issues, but not so sure), I think we can land this in 1.115.0.

@uenoku
Copy link
Member Author

uenoku commented Apr 24, 2025

@sequencer Can I merge this to 1.115?

@seldridge
Copy link
Member

@sequencer: You good with this for 1.115.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants