Skip to content

[Feature Request] option in General or Advanced settings to hide titlebar #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
acidjazz opened this issue Aug 13, 2019 · 10 comments · Fixed by #1038
Closed

[Feature Request] option in General or Advanced settings to hide titlebar #933

acidjazz opened this issue Aug 13, 2019 · 10 comments · Fixed by #1038
Labels
Feature Request New features request. Not an existing issue or bug. UI Issues related to UI elements, tabs, scrollbars, window resizing, etc.

Comments

@acidjazz
Copy link

Shot out to @splhack for #111 , would just be nice to be able to check a box in the MacVim options to hide the titlebar instead of having to run

$ defaults write org.vim.MacVim MMNoTitleBarWindow true
@eirnym
Copy link
Contributor

eirnym commented Aug 13, 2019

Thank you for a feature request, @acidjazz

I'd also prefer to have all options visible one way or another.

@ychin ychin added the Feature Request New features request. Not an existing issue or bug. label Aug 15, 2019
@mvcouwen
Copy link

I’d rather have an option to give the title bar a modern look similar to the ‘minimal’ look for iterm2. This look is based the appearance of Electron apps (https://www.iterm2.com/documentation-preferences-appearance.html). In my opinion this as useful as the titlebar but less distracting. Ofcourse having an option to completely remove the titlebar would already be a good first step.

@eirnym
Copy link
Contributor

eirnym commented Oct 17, 2019

@mvcouwen Could you add some screenshots for your idea? Could you also check if it already implemented (:help macvim)?

@mvcouwen
Copy link

Sure!

See e.g. this screenshot
this
from here.

This feature does not seem to be implemented.

@eirnym
Copy link
Contributor

eirnym commented Oct 17, 2019

Transparent titlebar is implemented. I agree, that tabs could be integrated to titlebar as well if a user wants.
Do you want to contribute implementation of them for MacVim?

@mvcouwen
Copy link

I would like to but I am afraid I don't know anything about the underlying code for macvim. Maybe I do in the future and then I might give it a try. That will not be anytime soon though.

@acidjazz
Copy link
Author

Love the minimal look, but also no title at all! Can we do both? maybe a new feature request @mvcouwen ?

@eirnym
Copy link
Contributor

eirnym commented Oct 17, 2019

@acidjazz no title at all is already implemented and documented :help macvim

@ychin
Copy link
Member

ychin commented Oct 21, 2019

In particular, do :help MMTitlebarAppearsTransparent.

I will be open to pull requests for a "modern style", although I'm a little weary of adding even more customization to window styles and tabs. Features are good but they add complexity and general maintainence cost, so I have to weigh how much value there is versus having to juggle multiple tabs implementation. Seems like iTerm has "Regular" (regular window with tabs below title), "Minimal" (big combined title / tabs bar), "Compact" (small regular size combined title / tabs bar). I think it's feasible to do something similar to "Compact" and just put the tab bar there, but there's a fair bit of code with assumptions of how the tabs work that I am not inclined to take that on now.

@mvcouwen I think you should probably make another issue instead of this one if you want that feature just to make it easier to have discussions specific to the feature.

@mvcouwen
Copy link

I have made another issue: #962.

@ychin ychin added the UI Issues related to UI elements, tabs, scrollbars, window resizing, etc. label Mar 5, 2020
ychin added a commit to ychin/macvim that referenced this issue Apr 13, 2020
Add new preference that allows specifying how MacVim will use dark mode:
use systems preference (default), force light mode, force dark mode, or
use Vim's 'background' option to decide. Preference will be stored in
defaults as 'MMAppearanceModeSelection'. Add docs for that as well.

Also, add a new preferences panel called "Appearance" to allow setting
the dark mode setting, and transparent titlebar as well. Setting it will
refresh all Vim windows immediately for feedback.

Also, when setting titlebars to transparent, also hide the file icon as
it's distracting in what's a more minimalistic display. Don't use
another preference for that for now to avoid having too many options.

Minor: Remove preference panel's cross-fade effect as it's more
distracting than useful.

Fix macvim-dev#912

Also:
- See macvim-dev#1015 for part of the contribution.
- Close macvim-dev#266
- Close macvim-dev#933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New features request. Not an existing issue or bug. UI Issues related to UI elements, tabs, scrollbars, window resizing, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants