-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GitLab OAuth client #4692
feat: add GitLab OAuth client #4692
Conversation
e92f942
to
9ae2b7e
Compare
As it turns out, I didn't find a place in the repository to document the added environment variables. Seems good to accompany this PR with a parallel one in makeplane/docs. |
9ae2b7e
to
59b86e9
Compare
Rebased to accommodate 36b82a7 |
59b86e9
to
b33ed0b
Compare
99e1963
into
makeplane:gitlab-oauth
Thank you for your contribution. We have merged your pull request into an internal branch for validation and testing. We will soon merge these changes into the |
Thanks! I'm very excited. Please test things out. The last rebase unfortunately removed the three commit version and put everything into a single commit again. I'm worried I've rebased the wrong branch, but hope I've catched the correct state of the implementation. Please let me know if you run into any issues. |
My intuition was correct. In trying to react quick with a rebase, I didn't fetch my force-pushed working branch from the other machine, which resulted in me pushing an outdated state of the PR. Thank you for being so diligent in checking this out into an internal testing branch. Please reset it hard by 🙈 |
Our team will take over from here. We will test it to ensure everything is working and address any issues that arise during the testing process. |
Thanks for the notice. Feel free to reuse, recommit or remix the content of the PRs in any way. Also feel free to close #4828, if suitable. |
This adds a GitLab OAuth client, based on the Google and GitHub examples.
To raise exceptions when OAuth is malconfigured, it also adds an additional
OAUTH_NOT_CONFIGURED
error.There is a bit of code duplication between admin, web and spaces, but that may be a design choice.
This has been tested successfully against a custom GitLab instance and should work similarly against the default instance.
addresses #408
addresses #413