-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GitLab OAuth client #4828
Conversation
Please review what when wrong with clicking on the "Resolve conflicts" button: The introduction of the convenience method I'm unable to give a reproducer at the moment, but there was a case during development, when |
* dev: oauth exception handling * dev: reset password on deactivation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes basically help to resolve the code duplication discussed in #4828 (comment)
Again, please excuse the earlier confusion with #4692 (comment) by incurring more work. |
c8edd7b
to
50a8969
Compare
a38b9b9
to
45d7fe0
Compare
Ready for review. |
45d7fe0
to
dbe534c
Compare
dbe534c
to
22f09a6
Compare
We have already squashed all your changes. We will review and fix things as a part of the internal release testing process. So closing this PR for now. |
This adds a GitLab OAuth client, based on the Google and GitHub examples.
This adds a new
authentication_error_code()
convenience method tooauth.py
, in order to reduce code duplication.To raise exceptions when OAuth is malconfigured, it also adds an additional
OAUTH_NOT_CONFIGURED
error.This also adds execute permission to the files apiserver/bin/docker-entrypoint-beat.sh and apiserver/bin/docker-entrypoint-migrator.sh, as it was a dependency to being able to develop. (#4630)
There is a bit of code duplication between admin, web and spaces, but that may be a design choice.
This has been tested successfully against a custom GitLab instance and should work similarly against the default instance.
addresses #408
addresses #413
closes #4630