Skip to content

Port fixes from master into release-2.5 #18360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 63 commits into from
Closed

Port fixes from master into release-2.5 #18360

wants to merge 63 commits into from

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Sep 9, 2017

Andy and others added 30 commits August 14, 2017 14:58
session.ts: Revert some emptyArray back to undefined (#17781)
eeb40fe 
* session.ts: Revert some `emptyArray` back to `undefined`

* Fix
@weswigham
Accept missing baseline updates for #13721
8f02979
In services, show the aliasSymbol for a type even if it's not accessi…
a5c9f40 
…ble in the current scope (#17810)
@DanielRosenwasser
Fixed lints.
f45ec92
@DanielRosenwasser
Merge pull request #17856 from Microsoft/synthesizedNamespaces
b326ac6 
[release-2.5] Fix emit for leading 'var' declarations for synthesized namespaces
@mhegazy
Revert public API changes to logger (#17901)
4e570f0
@DanielRosenwasser
Updated version for next publish.
b3ac765
@DanielRosenwasser
Accepted LKG
baeedab
@mhegazy
Ensure string enums are generated in protocol.d.ts
ba56b62
@mhegazy
Update LKG
3e5de59
@mhegazy
Merge branch 'EmitStringEnumsInProtocol' into release-2.5
f5698fc
@weswigham
Allow use before declaration for export= assignments (#17967) (#17972)
34e4209 
* Allow use before declaration for export= assignments (#17967)

* Add release-2.5 to covered branches
@mhegazy
Bind logger function before using (#17983)
1420fbc 
* Bind logger function before using

* Use lambda isntead of bind
@mhegazy
Port #17771 to release-2.5 (#18018)
6da73b0 
* No contextual return type when type is circular

* Add regression test
@rbuckton
Remove debug assertions due to invalid syntax in generators transform
952e9ca
@rbuckton
Fix crash when exporting class without name
80601fc
@Yogu @rbuckton
Add missing visitNode call to object literal members
09e7e88 
Object literal elements that are neither spread elements, nor property assignments would not have visitNode called on them. Therefore, the esnext transformer would not be called on them and their children.

Fixes #16765.
@Yogu @rbuckton
Add test case for nested object spread / methods
d48ac07 
See #16765.
@RyanCavanaugh @mhegazy
Ignore scripts for types packages (#17969)
13eeb34
@rbuckton
Follow symbol through commonjs require for inferred class type
ec8f5cf
@rbuckton
PR feedback
9bb1915
@rbuckton
Switch to arrow for ts class wrapper IIFE
01b7df6
@rbuckton
Added additional test
0851f69
@weswigham
Call dynamic import transform on expression used by export equal stat…
350c9f6 
…ement (#18028) (#18033)

* Call dynamic import transform on expression used by export equal statement

* Use Debug.fail
@weswigham
Fix crash when attempting to merge an import with a local declaration (…
a39ae1f 
…#18032) (#18034)

* There should be no crash when attempting to merge an import with a local declaration

* Show symbol has actually merged within the module
Test for action description of code actions, and simplify description…
3644771 
… for extracting method to file (#18030) (#18044)

* Test for action description of code actions, and simplify description for extracting method to file

* Add unit test file missing from tsconfig.json (only affects gulp) and update tests

* Use the actual number

* Use "module scope" or "global scope" instead of "this file"
@mhegazy
Don't try to extract import to a method: simpler fix (#18054)
62678cd
@rbuckton
Fix crash in name resolution with custom transforms and emitDecorator…
187a21c 
…Metadata
@mhegazy
Update LKG
2a2773f
@mhegazy
Update version
15a0d3f
sandersn and others added 25 commits August 31, 2017 13:51
@sandersn
Comment getTypeReferenceId and getRelationKey
0ff8eeb
@weswigham
Fix 18224 (#18259) (#18292)
16a4997 
* Probably fix 18224

* Corrected test
@mhegazy
Ensure that emitter calls callbacks (#18284) (#18325)
f5b9e30 
* Ensure that emitter calls calbacks

* Move new parameter to end of parameters

* Fix for ConditionalExpression

* Make suggested changes to emitter

* Fix parameter ordering

* Respond to minor comments

* Remove potentially expensive assertion

* More emitter cleanup
@mhegazy
Update version
8aaace0
@mhegazy
Update LKG
655145c
@sandersn
Disable lookahead in isStartOfParameter/isStartOfType
d3ce606
@sandersn
Test:disable lookahead in isStartOfParameter
7f639cc
@sandersn
Rename isStartOfType parameter used by isStartOfParameter
236eb1e
@mhegazy
extractMethod: Support renameLocation (#18351)
9434a81
@mhegazy
Update LKG
c476a08
@sandersn @mhegazy
Test: parsing of two-line @typedef jsdoc
319bc2b
@sandersn @mhegazy
Fix forEachChild's visit of JSDocTypedefTag
745dd6a 
Also remove JSDocTypeLiteral.jsdocTypeTag, which made no sense since it
was only useful when storing information for its parent `@typedef` tag.
@sandersn @mhegazy
Update baselines
de413a4
@sandersn @mhegazy
Inline variable to aid control flow
8b26919
@ahejlsberg @mhegazy
Improved caching scheme for anonymous types
9a5ddc0
@ahejlsberg @mhegazy
Fix signature help
5169542
@ahejlsberg @mhegazy
Optimize caching of type literals
9711d66
@ahejlsberg @mhegazy
Accept new baselines
ee7e77a
@ahejlsberg @mhegazy
Fix linting errors
00cede1
@ahejlsberg @mhegazy
Use canonicalized forms when comparing signatures
3f37044
@ahejlsberg @mhegazy
Minor changes
8ef188e
@amcasey @mhegazy
Document ThrottledOperations.schedule
1ea1995
@amcasey @mhegazy
Limit the number of unanswered typings installer requests
dd9f4a1 
If we send them all at once, we (apparently) hit a buffer limit in the
node IPC channel and both TS Server and the typings installer become
unresponsive.
@amcasey @mhegazy
Fix lint issues
40c34d1
@amcasey @mhegazy
Add explanatory comment
c505bc4
@mhegazy mhegazy closed this Sep 9, 2017
@mhegazy mhegazy deleted the PortFromMaster branch September 9, 2017 19:54
@kondi kondi mentioned this pull request Sep 19, 2017
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mhegazy @msftclas @weswigham @DanielRosenwasser @rbuckton @Yogu @RyanCavanaugh @ahejlsberg @sandersn @amcasey