-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Added --preserveWatchOutput flag #21303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --preserveWatchOutput flag #21303
Conversation
Maybe it would be better if the screen clearing was behind a flag. This way the new option would be a pure addition with the current behaviour unaltered. |
@gcnew Ehh, I really like the new behavior. It's quite useful on large projects. The lack of complaints from insiders makes me (without any experience tracking these things) suspect it wouldn't be too bad. |
I like the new behavior by default as well, but @mhegazy You mentioned that you don't want to add new flags (#21295 (comment)). Perhaps if could be generalized to a single flag which disables all tty view manipulation now and in the future. Even more generalized to disable any sort of interactivity. For yarn, this is If the ability to disable this feature isn't added, I (and others) will need to write a thin wrapper to |
#21295 (comment) by @clarkdave posted a working fix |
@JoshuaKGoldberg Why did you close the PR? The fix mentioned by @roblav96 doesn't work for Mac users (I don't want to force everyone in my team to install gsed). |
I closed the PR because a core TS member (mhegazy) mentioned last month that they don't want to add a compiler option for this, and since then it's obtained a few merge conflicts. You're welcome to send a new one & try to push for it though! |
On second thought, @mhegazy, what are your thoughts on switching this flag to be opt-in? It sounds like this change broke a lot of people (sorry folks!). I'll resolve the merge conflicts today regardless. |
Description: "Whether to keep outdated console output in watch mode instead of clearing the screen." Since the `pretty?` compiler options flag is marked as `@internal`, made this one too.
48b52a8
to
3b374cd
Compare
I've sent a second PR, #22248, that has the equivalent change to make the behavior opt-in with a new --clearWatchOutput` flag. IMO that's a better fix. |
Does not show up locally and does not relate to this change. Unrelated? |
thanks! |
Description: "Whether to keep outdated console output in watch mode instead of clearing the screen."
Since the
pretty?
compiler options flag is marked as@internal
, made this one too.Fixes #21295. Sending a PR before the issue is approved to increase probability of this shipping the same time as the clearing feature.