Skip to content

Added --clearWatchOutput flag #22248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

JoshuaKGoldberg
Copy link
Contributor

Makes the 2.7 behavior of clearing the console on recompiles opt-in.

Description: "Whether to clear the console in watch mode on new results."
Since the pretty? compiler options flag is marked as @internal, made this one too.

Sibling PR to #21303. IMO this is a better fix, as the added behavior of clearing the console has proven itself troublesome.

Fixes #21295.

Description: "Whether to clear the console in watch mode on new results."
Since the `pretty?` compiler options flag is marked as `@internal`, made this one too.
@JoshuaKGoldberg
Copy link
Contributor Author

16:14:16   59316 passing (2m)
16:14:16   1 failing
16:14:16 
16:14:16   1) conformance tests
16:14:16        conformance tests for tests/cases/conformance/types/uniqueSymbol/uniqueSymbolsErrors.ts
16:14:16          Correct errors for tests/cases/conformance/types/uniqueSymbol/uniqueSymbolsErrors.ts:
16:14:16      Error: The baseline file uniqueSymbolsErrors.errors.txt has changed.

Does not show up locally and does not relate to this change. Unrelated?

@weswigham
Copy link
Member

#22247 fixes the build break

@mhegazy
Copy link
Contributor

mhegazy commented Mar 1, 2018

#21303 is merged now, I do not think we want to change the default yet again.

@mhegazy mhegazy closed this Mar 1, 2018
@JoshuaKGoldberg JoshuaKGoldberg deleted the clear-watch-output branch March 1, 2018 19:55
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow not clearing the console on recompiles in --pretty --watch mode
3 participants