bigint support for GridRowId #9804
Conversation
Signed-off-by: Payam Moghaddam <pmoghaddam@users.noreply.github.com>
Netlify deploy previewNetlify deploy preview: https://deploy-preview-9804--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
zannager
added
the
component: data grid
| @@ -182,7 +182,7 @@ export type GridRowTreeConfig = Record<GridRowId, GridTreeNode>; | |||
| /** | |||
| * The type of Id supported by the grid. | |||
| */ | |||
| export type GridRowId = string | number; | |||
| export type GridRowId = string | number | bigint; | |||
There was a problem hiding this comment.
This makes sense to me, but the problem is that bigint cannot be used as an index type.
There is an open issue in the TypeScript repo: microsoft/TypeScript#46395
Given the above, I'm not sure we can support it.
Any thoughts? cc @romgrk
There was a problem hiding this comment.
Interesting. Didn't know it was TypeScript oriented. Hmmm, need to figure out a workaround. There is so much type casting and conversion going on to quiet the compiler, it's making the code harder to read. If there is a recommendation, I'd appreciate it.
|
Will close this for now to reduce noise. I'll instead follow TS's issue. |
I am raising this for your attention. It seems like a simple fix, but not sure if I am missing anything. If you got an override option for temporary support, I'd appreciate it.