Skip to content

bigint support for GridRowId #9804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bigint support for GridRowId #9804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid/src/models/gridRows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export type GridRowTreeConfig = Record<GridRowId, GridTreeNode>;
/**
* The type of Id supported by the grid.
*/
export type GridRowId = string | number;
export type GridRowId = string | number | bigint;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, but the problem is that bigint cannot be used as an index type.
There is an open issue in the TypeScript repo: microsoft/TypeScript#46395

Given the above, I'm not sure we can support it.
Any thoughts? cc @romgrk

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Didn't know it was TypeScript oriented. Hmmm, need to figure out a workaround. There is so much type casting and conversion going on to quiet the compiler, it's making the code harder to read. If there is a recommendation, I'd appreciate it.


export interface GridRowEntry<R extends GridValidRowModel = GridValidRowModel> {
/**
Expand Down