Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plink/indep nf-test migration #8132

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

andresferben
Copy link
Contributor

@andresferben andresferben commented Mar 26, 2025

Description

Migration of plink/indep tests from pytest to nf-test following the steps listed in #7654.

PR checklist

Closes #7663

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@andresferben andresferben requested a review from a team as a code owner March 26, 2025 16:06
@andresferben andresferben self-assigned this Mar 26, 2025
Copy link
Member

@kenibrewer kenibrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and can be merged as soon as additional documentation is added to the pull request description.

Also, please check the boxes that you completed.

@andresferben andresferben added this pull request to the merge queue Mar 26, 2025
Merged via the queue into nf-core:master with commit 609a04d Mar 26, 2025
16 checks passed
@andresferben andresferben deleted the plink/indep_nftest branch March 26, 2025 20:19
zachary-foster pushed a commit to zachary-foster/modules that referenced this pull request Mar 27, 2025
Dewey-Wang pushed a commit to Dewey-Wang/modules that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

nf-test migration: plink/indep
4 participants