Skip to content

Value object and arguments with the name ApiToken|$apiToken should be ApiKey|$apiKey #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nunomaduro opened this issue Dec 28, 2022 · 2 comments
Closed

Value object and arguments with the name ApiToken|$apiToken should be ApiKey|$apiKey #23

nunomaduro opened this issue Dec 28, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@nunomaduro
Copy link
Contributor

We've just noticed that, within this project, we are using the terminology ApiToken and $apiToken, where in fact, it should ApiKey and $apiKey, as mentioned in multiple places in OpenAI documention.
@nunomaduro nunomaduro added the good first issue Good for newcomers label Dec 28, 2022
@aifodu aifodu mentioned this issue Dec 28, 2022
Closed
@filips-dev
Copy link

@nunomaduro Seeing as I'm new to Open source how can I push my branch and make a PR?

aifodu added a commit to aifodu/client that referenced this issue Dec 28, 2022
@aifodu
refactor: rename token to key
8c10b29 
openai-php#23
@iamharis010 iamharis010 mentioned this issue Dec 28, 2022
Closed
aifodu added a commit to aifodu/client that referenced this issue Dec 28, 2022
@aifodu
refactor: rename class names from token to key
bae4c5b 
openai-php#23
@iamharis010 iamharis010 mentioned this issue Dec 28, 2022
Closed
@harishpatel143 harishpatel143 mentioned this issue Dec 28, 2022
Closed
nunomaduro added a commit that referenced this issue Dec 28, 2022
@nunomaduro
Merge pull request #25 from filips-dev/#23-Fix-Naming-Of-ApiToken
9f5f1ae 
Naming fixed of ApiKey and variable names
@nunomaduro
Copy link
Contributor Author

Fixed here: #25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nunomaduro @filips-dev