refactor: rename token to key #24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename ApiToken to ApiKey and $apiToken to $apiKey across the project 23
|
@aifodu Tests are failing. Can you take a look? |
Plytas
reviewed
Dec 28, 2022
Plytas
suggested changes
Dec 28, 2022
There was a problem hiding this comment.
Whole .idea folder got committed now.
@nunomaduro there's also #25 that seems to be clean and with passing tests.
|
Yes, #25 is clean and passes everything. Thanks @Plytas and @nunomaduro for taking a look. Tremendous job guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename ApiToken to ApiKey and $apiToken to $apiKey across the project
Fixes issue #23