Skip to content

Make the appropriate spi_mode_* Efs field mandatory #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daym opened this issue Jun 26, 2023 · 0 comments · Fixed by #157
Closed

Make the appropriate spi_mode_* Efs field mandatory #141

daym opened this issue Jun 26, 2023 · 0 comments · Fixed by #157
Assignees
@daym

Comments

@daym
Copy link
Collaborator

daym commented Jun 26, 2023 •
edited
Loading

Currently, the Efs spi_mode_* are all optional and all default to 0xff.

Not having an entry for the selected CPU generation is bad since the possible SPI speed one can physically use depends on the mainboard's electrical design--and cannot be guessed.
@daym daym self-assigned this Jun 26, 2023
@daym daym changed the title Make the appropriate spi_mode_* field mandatory Make the appropriate spi_mode_* Efs field mandatory Jun 26, 2023
@daym daym mentioned this issue Jun 27, 2023
Closed
daym pushed a commit that referenced this issue Jul 24, 2023
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
20693a2 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid

Fixes <#141>.
@daym daym mentioned this issue Jul 24, 2023
Merged
daym pushed a commit that referenced this issue Aug 1, 2023
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
4600865 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid

Fixes <#141>.
daym pushed a commit that referenced this issue Sep 4, 2023
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
f6f50d4 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid

Fixes <#141>.
daym pushed a commit that referenced this issue Sep 4, 2023
@daym
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
80b6df9 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid

Fixes <#141>.
daym added a commit that referenced this issue Sep 4, 2023
@daym
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
65f43ea 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
2be16dd 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
6f14f2d 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
51fdffa 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
43f4375 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
4b776ad 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
c6f11a6 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
191500c 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
6854ef1 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
30e9cab 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen…
504e05d 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor_generation, spi_mode_bulldozer, spi_mode_zen…
5ca7506 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor_generation, spi_mode_bulldozer, spi_mode_zen…
adf58ab 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor_generation, spi_mode_bulldozer, spi_mode_zen…
4f1d5f7 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor_generation, spi_mode_bulldozer, spi_mode_zen…
e640b61 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor_generation, spi_mode_bulldozer, spi_mode_zen…
f794594 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor_generation, spi_mode_bulldozer, spi_mode_zen…
6ee973d 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor_generation, spi_mode_bulldozer, spi_mode_zen…
3fcc9c1 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor_generation, spi_mode_bulldozer, spi_mode_zen…
eecadeb 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Sep 21, 2023
@daym
Check whether (processor_generation, spi_mode_bulldozer, spi_mode_zen…
ef4495e 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
daym added a commit that referenced this issue Dec 4, 2023
@daym
Check whether (processor_generation, spi_mode_bulldozer, spi_mode_zen…
ce69eea 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
@daym daym closed this as completed in #157 Dec 7, 2023
daym added a commit that referenced this issue Dec 7, 2023
@daym
Check whether (processor_generation, spi_mode_bulldozer, spi_mode_zen…
24f0613 
…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daym daym

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@daym