Skip to content

Check whether (processor generation, spi_mode_bulldozer, spi_mode_zen… #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

daym
Copy link
Collaborator

@daym daym commented Jul 24, 2023

…_naples, spi_mode_zen_rome) that was specified by the user is actually valid

Fixes #141.

@daym daym requested a review from dancrossnyc July 24, 2023 09:14
@daym daym force-pushed the issue-141 branch 3 times, most recently from 80b6df9 to 65f43ea Compare September 4, 2023 15:49
@daym daym force-pushed the issue-141 branch 7 times, most recently from c6f11a6 to 191500c Compare September 21, 2023 19:33
@daym daym marked this pull request as ready for review September 21, 2023 19:47
@daym daym force-pushed the issue-141 branch 12 times, most recently from eecadeb to ef4495e Compare September 21, 2023 20:34
@daym daym requested a review from luqmana November 27, 2023 22:12
Copy link
Contributor

@luqmana luqmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good a few small nits aside, thanks!

…_naples, spi_mode_zen_rome) that was specified by the user is actually valid.

Fixes <#141>.
Copy link
Contributor

@dancrossnyc dancrossnyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@daym daym merged commit 24f0613 into main Dec 7, 2023
@daym daym deleted the issue-141 branch December 7, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the appropriate spi_mode_* Efs field mandatory
3 participants