Add per-beatmap team ranking #11989
Merged
Add per-beatmap team ranking #11989
+33
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
reviewed
Mar 11, 2025
| @@ -36,7 +36,7 @@ public function __construct() | |||
| private static function assertSupporterOnlyOptions(?User $currentUser, string $type, array $mods): void | |||
| { | |||
| $isSupporter = $currentUser !== null && $currentUser->isSupporter(); | |||
| if ($type !== 'global' && !$isSupporter) { | |||
| if (!in_array($type, ScoreSearchParams::FREE_TYPES, true) && !$isSupporter) { | |||
There was a problem hiding this comment.
wonder if it makes more sense to make it SUPPORTER_TYPES now if the condition is no longer simply !== 'global'
notbakaneko
requested changes
Mar 11, 2025
| return 'supporter_only'; | ||
| } | ||
|
|
||
| return this.xhrState; | ||
| } | ||
|
|
||
| get requiresSupporter() { | ||
| return !['global', 'team'].includes(this.currentType) || this.enabledMods.size > 0; |
There was a problem hiding this comment.
can be a const Set<ScoreboardType> (also maybe make it match against supporter required instead of not free)
notbakaneko
approved these changes
Mar 12, 2025
|
I'm adding client-side support for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤷