Add team beatmap leaderboards #32360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
force-pushed
the
add-team-beatmap-leaderboards
branch
from
a37b6fc to
b0cf5e8
Compare
bdach
reviewed
Mar 13, 2025
Comment on lines
+45
to
+47
| case BeatmapLeaderboardScope.Team: | ||
| text.Text = BeatmapsetsStrings.ShowScoreboardNoScoresTeam; | ||
| break; |
There was a problem hiding this comment.
Checking web, web just doesn't show the team scope if you're not on a team... Not sure if this is an issue or not? It definitely may be pretty annoying to match web given how TabControl can be a bit jank...
There was a problem hiding this comment.
Yeah just going with it for now.
|
Aside from the above, seems to work as advertised |
bdach
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with ppy/osu-web#11989.