-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Add autoscale tail ignore via popup #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 84.76% 85.06% +0.30%
==========================================
Files 45 45
Lines 4633 4694 +61
==========================================
+ Hits 3927 3993 +66
+ Misses 706 701 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thanks @gselzer, this would indeed be great to have. Couple thoughts at this point:
|
Good ideas. Have updated in the latest commit: If you're a fan of this now I'll investigate how/whether we can do similar things in wx (where I'm more confident) and jupyter (less confident) |
Yes, but I agree that separate settings are sometimes desirable. I thought a bit about whether people would want the option of editing just one number, but then again, it doesn't make theoretical sense to use the same number for the read noise at the bottom and the shot noise at the top (for example). It would only be a heuristic convenience. Given that in many cases you'd only need a non-zero percentile for the upper limit (I think?), it seems fine (and simplest) to just have two fields. |
@tlambert03 I've been tinkering with a Jupyter version (aided by Claude) over the past few days, but I think I'd like to put that work on a separate branch, as I really want this functionality for qt right now. Any objections to punting on the jupyter functionality for now? Still planning to investigate wx in the meantime |
8a834a9
to
5418317
Compare
not at all. Similar to the play button, it’s fine with me if features hit different front ends at different times |
Not really used :)
@tlambert03 I'm pretty happy with these changes, if you'd like to take another look feel free, but can also just merge. There's one bug I'm aware of but have not yet found a solution for - the tail edit controls for wx do not seem to be editable with keyboard. You can still edit it with the spin buttons (and that will be enough control for e.g. ignoring outliers) so I'm tempted to just merge and file an issue for this - thoughts? |
functionality is great. I find myself thinking/wondering about the terminology "tail" and "ignore" in "ignore upper/lower tail". I'm ok with that, but it's not strictly always "tail shaped"... some alternatives to consider (but if you prefer tail over all of these thats ok too:)
so:
thoughts? we could also have a checkbox that toggles all of it, so you can go back to min/max without changing the percentile values?
|
I can edit them, but it's awkward to "enter" ... (hitting enter doesn't work, I need to defocus) ... lemme try edit: yeah: this is awkward... and I don't know how to fix it after trying a few things that i thought would have worked. (it's ok with me to leave this for later... it's not the only wx interface thing that is sub-optimal |
Yeah, I like
Maybe - I was originally thinking tabs here, in case we want to add in controls for |
sure, let's consider in another PR |
Alright, I'll merge this after renaming the labels and create followup issues for (a) the Jupyter implementation and (b) the wx bug and (c) some toggle to retain settings when transitioning to manual mode. |
This PR adds GUI functionality for autoscaling using
ClimsPercentile
, where the user can ignore the outlier samples of the dataset being displayed in autoscale:Recording.2025-02-28.214155.mp4
I like the placement as a context menu because it means all autoscaling functionality appears within the same area of the canvas and because it normally does not take up any screen space.
Unfortunately, I do not know whether this design is possible with all our frontends, seeing as how I cannot figure out how to write a context menu in ipywidgets.
We might instead have to settle for adding this widget to the layouts added in #146...