Skip to content

Histogram hscroll pan #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 17, 2025
Merged

Conversation

gselzer
Copy link
Collaborator

@gselzer gselzer commented Apr 16, 2025

This PR enables panning histograms using horizontal scroll in both vispy and pygfx.

TODO:

  • Clean up
  • Test

Closes #172

@gselzer gselzer added the enhancement New feature or request label Apr 16, 2025
@gselzer gselzer requested a review from tlambert03 April 16, 2025 19:35
@gselzer gselzer self-assigned this Apr 16, 2025
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.21%. Comparing base (428fd96) to head (1e80365).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/ndv/views/_pygfx/_histogram.py 83.33% 2 Missing ⚠️
src/ndv/views/_vispy/_plot_widget.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   84.56%   85.21%   +0.65%     
==========================================
  Files          45       45              
  Lines        4521     4713     +192     
==========================================
+ Hits         3823     4016     +193     
+ Misses        698      697       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gselzer
Copy link
Collaborator Author

gselzer commented Apr 16, 2025

@tlambert03 I'm pretty happy with this, works nicely with both mouse and trackpad. Since you requested the feature, thoughts?

@tlambert03 tlambert03 marked this pull request as ready for review April 17, 2025 12:08
Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks/works good! thanks

@tlambert03 tlambert03 merged commit 5f42c40 into pyapp-kit:main Apr 17, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: horizontal scrolling via mouse wheel on histogram
2 participants