Skip to content

Merge master into features #4887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 65 commits into from
Mar 5, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Mar 5, 2019

No description provided.

blueyed and others added 30 commits February 26, 2019 12:57
`brew update` and `brew upgrade python` is very slow.

This uses the existing `/usr/local/bin/python3` (3.7.0).
ci: Travis: use single install section
Should be covered by Azure.
Also changed how the section is presented: instead of "Note" blocks, use proper
sections as those contain enough information to exist on their own.

Fix pytest-dev#1680
This appears to improve performance - ~4s with `tox -e py37-coverage --
testing/test_collection.py`.
This should not be necessary (anymore).
Co-Authored-By: nicoddemus <nicoddemus@gmail.com>
…riting

Document how to disable caching rewritten .pyc files to disk
coverage: use run.include, remove --ignore-errors, send TOXENV as name to codecov
Previously it was not run with a) xdist ("-c"), and b) "python -m
pytest" ("…/pytest.py", not executable).
blueyed and others added 21 commits March 1, 2019 18:26
Apparently this caused missing coverage with pdb/pexpect tests.
tox: split default posargs, use --lsof with single job only
Add missing ref docs to tmp_path and tmp_path_factory
.coveragerc: use globs with includes
tox: generic pluggymaster factor, remove env hack
It fails reliable for me now without the fix from 9517c3a.

Ref: pytest-dev#2370
…sing_tmpfile_py27

tests: make test_crash_on_closing_tmpfile_py27 more reliable
PyPy uses "site-packages" directly.
While this is not used currently, it is still good for having it covered
(it failed when running coverage with all jobs unconditionally).
ci: azure: fix coverage reporting with PyPy (not used currently)
It was enabled accidentally.
Fix master: ci: Azure: remove pypy3
This brings coverage back that got missing with 9dcd6f2.

Continuation of pytest-dev#4839 / pytest-dev#4846.
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #4887 into features will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #4887      +/-   ##
============================================
- Coverage     95.75%   95.71%   -0.05%     
============================================
  Files           113      113              
  Lines         25765    25266     -499     
  Branches       2511     2504       -7     
============================================
- Hits          24671    24183     -488     
+ Misses          775      767       -8     
+ Partials        319      316       -3
Flag Coverage Δ
#linux ?
#osx ?
#windows ?
Impacted Files Coverage Δ
testing/test_warnings.py 98.9% <ø> (-0.11%) ⬇️
src/_pytest/main.py 96.01% <ø> (+0.17%) ⬆️
src/_pytest/mark/structures.py 92.61% <ø> (-0.13%) ⬇️
src/_pytest/assertion/truncate.py 92.45% <ø> (ø) ⬆️
src/_pytest/deprecated.py 100% <ø> (ø) ⬆️
src/_pytest/hookspec.py 100% <ø> (ø) ⬆️
testing/code/test_source.py 95.53% <ø> (-1.07%) ⬇️
testing/test_resultlog.py 100% <ø> (ø) ⬆️
src/_pytest/pathlib.py 90.65% <ø> (ø) ⬆️
src/_pytest/logging.py 94.96% <ø> (-0.31%) ⬇️
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ea04f...7668703. Read the comment docs.

@blueyed
Copy link
Contributor Author

blueyed commented Mar 5, 2019

Codecov does not appear to handle the removal of flags, or rather the changes to .coveragerc well with "Changes".
LGTM.

@blueyed blueyed merged commit 4668ee0 into pytest-dev:features Mar 5, 2019
@blueyed blueyed deleted the merge-master-into-features branch March 5, 2019 22:05
@blueyed
Copy link
Contributor Author

blueyed commented Mar 5, 2019

@RonnyPfannschmidt @nicoddemus
Used the admin-override again, but will keep it enabled now.
I've also enabled WIP to be required for features, and Travis, Azure, and codecov/patch for both branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants