Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[telemetry] RLlib should not report usage on import #51166

Open
edoakes opened this issue Mar 7, 2025 · 0 comments
Open

[telemetry] RLlib should not report usage on import #51166

edoakes opened this issue Mar 7, 2025 · 0 comments
Labels
P1 Issue that should be fixed within a few weeks rllib RLlib related issues

Comments

@edoakes
Copy link
Collaborator

edoakes commented Mar 7, 2025

Libraries should report usage only when a relevant API is used, not when they are imported.

Un-skip this test case: https://github.com/ray-project/ray/pull/51161/files#diff-223a4454f64b8d38669989a2f91f3d9c9910c58d1690ca05541485342c2d52b3R20
@edoakes edoakes added P1 Issue that should be fixed within a few weeks rllib RLlib related issues labels Mar 7, 2025
@edoakes edoakes mentioned this issue Mar 7, 2025
Merged
8 tasks
edoakes added a commit that referenced this issue Mar 8, 2025
@edoakes
[telemetry] Move library usage tests out of core (#51161)
11e886c 
Splits the tests for library-specific telemetry data into their own test
files. Each one has a similarly-structured test with a shared utility
for common logic.

This exercise many issues in the telemetry that we need to address in
follow ups:

- #51163
- #51164
- #51165
- #51166
- #51167
- #51168

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
elimelt pushed a commit to elimelt/ray that referenced this issue Mar 9, 2025
@edoakes @elimelt
[telemetry] Move library usage tests out of core (ray-project#51161)
312452e 
Splits the tests for library-specific telemetry data into their own test
files. Each one has a similarly-structured test with a shared utility
for common logic.

This exercise many issues in the telemetry that we need to address in
follow ups:

- ray-project#51163
- ray-project#51164
- ray-project#51165
- ray-project#51166
- ray-project#51167
- ray-project#51168

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
park12sj pushed a commit to park12sj/ray that referenced this issue Mar 18, 2025
@edoakes @park12sj
[telemetry] Move library usage tests out of core (ray-project#51161)
0259765 
Splits the tests for library-specific telemetry data into their own test
files. Each one has a similarly-structured test with a shared utility
for common logic.

This exercise many issues in the telemetry that we need to address in
follow ups:

- ray-project#51163
- ray-project#51164
- ray-project#51165
- ray-project#51166
- ray-project#51167
- ray-project#51168

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
jaychia pushed a commit to jaychia/ray that referenced this issue Mar 19, 2025
@edoakes @jaychia
[telemetry] Move library usage tests out of core (ray-project#51161)
e5e1c03 
Splits the tests for library-specific telemetry data into their own test
files. Each one has a similarly-structured test with a shared utility
for common logic.

This exercise many issues in the telemetry that we need to address in
follow ups:

- ray-project#51163
- ray-project#51164
- ray-project#51165
- ray-project#51166
- ray-project#51167
- ray-project#51168

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Jay Chia <17691182+jaychia@users.noreply.github.com>
jaychia pushed a commit to jaychia/ray that referenced this issue Mar 19, 2025
@edoakes @jaychia
[telemetry] Move library usage tests out of core (ray-project#51161)
11cac95 
Splits the tests for library-specific telemetry data into their own test
files. Each one has a similarly-structured test with a shared utility
for common logic.

This exercise many issues in the telemetry that we need to address in
follow ups:

- ray-project#51163
- ray-project#51164
- ray-project#51165
- ray-project#51166
- ray-project#51167
- ray-project#51168

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Jay Chia <17691182+jaychia@users.noreply.github.com>
Drice1999 pushed a commit to Drice1999/ray that referenced this issue Mar 23, 2025
@edoakes @Drice1999
[telemetry] Move library usage tests out of core (ray-project#51161)
ebeeaaa 
Splits the tests for library-specific telemetry data into their own test
files. Each one has a similarly-structured test with a shared utility
for common logic.

This exercise many issues in the telemetry that we need to address in
follow ups:

- ray-project#51163
- ray-project#51164
- ray-project#51165
- ray-project#51166
- ray-project#51167
- ray-project#51168

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
dhakshin32 pushed a commit to dhakshin32/ray that referenced this issue Mar 27, 2025
@edoakes
[telemetry] Move library usage tests out of core (ray-project#51161)
12c4e4e 
Splits the tests for library-specific telemetry data into their own test
files. Each one has a similarly-structured test with a shared utility
for common logic.

This exercise many issues in the telemetry that we need to address in
follow ups:

- ray-project#51163
- ray-project#51164
- ray-project#51165
- ray-project#51166
- ray-project#51167
- ray-project#51168

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 Issue that should be fixed within a few weeks rllib RLlib related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edoakes