New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[telemetry] Move library usage tests out of core #51161

Merged

edoakes merged 30 commits into ray-project:master from edoakes:eoakes/mv-library-usage

Mar 8, 2025

Collaborator

edoakes commented Mar 7, 2025 •

edited

Loading

Why are these changes needed?

Splits the tests for library-specific telemetry data into their own test files. Each one has a similarly-structured test with a shared utility for common logic.

This exercise many issues in the telemetry that we need to address in follow ups:

Related issue number

Checks

I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/master/.
- I've added any new APIs to the API Reference. For example, if I added a
  method in Tune, I've added it in doc/source/tune/api/ under the
  corresponding .rst file.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

edoakes added 16 commits

February 14, 2025 11:23

fix

7e77851

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

wip

2ad7479

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>


          Merge branch 'master' of https://github.com/ray-project/ray into eoak…

e1d4dc4

…es/mask-data-dir

wip

31ee1cc

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

fix

1840c69

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

fix

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

fix

4e19350

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>


          Merge branch 'master' of https://github.com/ray-project/ray into eoak…

9f6d678

…es/mask-rllib-dir

fix

ff685e6

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

fix

2aa233d

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

fix

6cc849a

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

WIP

9db6774

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

fix

2f61110

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

fix

48e8a91

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>


          comment

32617de

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

fix

714c91d

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

edoakes requested review from sven1977, simonsays1980 and a team as code owners

March 7, 2025 16:34

edoakes added 3 commits

March 7, 2025 10:37

fix

0f38bb3

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

fix

525ea66

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

fix

4103fb3

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

edoakes requested review from hongpeng-guo, justinvyu, matthewdeng, raulchen and woshiyyya as code owners

March 7, 2025 16:51

edoakes changed the title ~~[WIP] Move library usage tests out of core tests~~ Move library usage tests out of core

edoakes changed the title ~~Move library usage tests out of core~~ Move library telemetry tests out of core

fix

ebac432

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

edoakes added 4 commits

March 7, 2025 11:28

fix

86ecba3

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

fix

f6ae3fb

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

fix

a3da9c7

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

fix

6338b96

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

edoakes mentioned this pull request

[telemetry] Using only library APIs should not cause "core" usage to be reported #51169

Closed

edoakes changed the title ~~Move library telemetry tests out of core~~ [telemetry] Move library usage tests out of core

fix

408e681

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

Collaborator Author

edoakes commented Mar 7, 2025

@sven1977 @justinvyu @raulchen @matthewdeng please review the relevant files and stamp for codeowner

raulchen approved these changes

View reviewed changes

fix

7760d73

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

matthewdeng approved these changes

View reviewed changes

Contributor

matthewdeng left a comment

train/tune looks good for current state. I can update tests in my PR to reflect desired behavior.

simonsays1980 approved these changes

View reviewed changes

Collaborator

simonsays1980 left a comment

LGTM. All good on RLlib side.

edoakes added the go label

edoakes enabled auto-merge (squash)

March 7, 2025 20:43

fix

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

github-actions bot disabled auto-merge

March 7, 2025 21:22

edoakes added 3 commits

March 7, 2025 16:14

fix

e678854

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

fix

241fb04

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>


          Merge branch 'master' of https://github.com/ray-project/ray into eoak…

1a0bc4b

…es/mv-library-usage

edoakes enabled auto-merge (squash)

March 7, 2025 22:17

edoakes merged commit 11e886c into ray-project:master

6 checks passed

elimelt pushed a commit to elimelt/ray that referenced this pull request


          [telemetry] Move library usage tests out of core (ray-project#51161)

312452e

Splits the tests for library-specific telemetry data into their own test
files. Each one has a similarly-structured test with a shared utility
for common logic.

This exercise many issues in the telemetry that we need to address in
follow ups:

- ray-project#51163
- ray-project#51164
- ray-project#51165
- ray-project#51166
- ray-project#51167
- ray-project#51168

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

park12sj pushed a commit to park12sj/ray that referenced this pull request


          [telemetry] Move library usage tests out of core (ray-project#51161)

Splits the tests for library-specific telemetry data into their own test
files. Each one has a similarly-structured test with a shared utility
for common logic.

This exercise many issues in the telemetry that we need to address in
follow ups:

- ray-project#51163
- ray-project#51164
- ray-project#51165
- ray-project#51166
- ray-project#51167
- ray-project#51168

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

jaychia pushed a commit to jaychia/ray that referenced this pull request


          [telemetry] Move library usage tests out of core (ray-project#51161)

e5e1c03

Splits the tests for library-specific telemetry data into their own test
files. Each one has a similarly-structured test with a shared utility
for common logic.

This exercise many issues in the telemetry that we need to address in
follow ups:

- ray-project#51163
- ray-project#51164
- ray-project#51165
- ray-project#51166
- ray-project#51167
- ray-project#51168

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Jay Chia <17691182+jaychia@users.noreply.github.com>

jaychia pushed a commit to jaychia/ray that referenced this pull request


          [telemetry] Move library usage tests out of core (ray-project#51161)

11cac95

Splits the tests for library-specific telemetry data into their own test
files. Each one has a similarly-structured test with a shared utility
for common logic.

This exercise many issues in the telemetry that we need to address in
follow ups:

- ray-project#51163
- ray-project#51164
- ray-project#51165
- ray-project#51166
- ray-project#51167
- ray-project#51168

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Jay Chia <17691182+jaychia@users.noreply.github.com>

Drice1999 pushed a commit to Drice1999/ray that referenced this pull request


          [telemetry] Move library usage tests out of core (ray-project#51161)

ebeeaaa

Splits the tests for library-specific telemetry data into their own test
files. Each one has a similarly-structured test with a shared utility
for common logic.

This exercise many issues in the telemetry that we need to address in
follow ups:

- ray-project#51163
- ray-project#51164
- ray-project#51165
- ray-project#51166
- ray-project#51167
- ray-project#51168

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>

dhakshin32 pushed a commit to dhakshin32/ray that referenced this pull request


          [telemetry] Move library usage tests out of core (ray-project#51161)

12c4e4e

Splits the tests for library-specific telemetry data into their own test
files. Each one has a similarly-structured test with a shared utility
for common logic.

This exercise many issues in the telemetry that we need to address in
follow ups:

- ray-project#51163
- ray-project#51164
- ray-project#51165
- ray-project#51166
- ray-project#51167
- ray-project#51168

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

simonsays1980 simonsays1980 approved these changes

raulchen raulchen approved these changes

matthewdeng matthewdeng approved these changes

sven1977 Awaiting requested review from sven1977 sven1977 is a code owner

hongpeng-guo Awaiting requested review from hongpeng-guo hongpeng-guo is a code owner

justinvyu Awaiting requested review from justinvyu justinvyu is a code owner

woshiyyya Awaiting requested review from woshiyyya woshiyyya is a code owner

Labels

go